Add vertical upset plot visualization feature - #32
Open
edmundmiller wants to merge 2 commits into
Open
Conversation
Implemented a new 'orientation' parameter for UpSet plots that allows switching between horizontal and vertical layouts: - Horizontal (default): cardinality bars on top (vertical), set sizes on right (horizontal) - Vertical (new): cardinality bars on left (horizontal), set sizes on top (vertical) Changes: - Added 'orientation' parameter to UpSetAltair() function with validation - Updated create_vertical_bar() to support both orientations by swapping X/Y axes - Updated create_matrix_view() to swap axes for vertical orientation - Updated create_horizontal_bar() to support vertical layout with Y-axis for set sizes - Refactored layout logic to use hconcat for vertical orientation - Added comprehensive tests for vertical orientation - Updated test normalization to handle auto-generated param and view names All existing tests pass, and the feature is fully backward compatible.
Updated documentation to include the new vertical orientation feature: - Added vertical orientation to README features list - Added "Vertical Orientation" section to README advanced usage - Updated CHANGELOG with unreleased version entry - Added comprehensive examples to advanced_features.rst showing: - Vertical orientation usage - Comparison between horizontal and vertical layouts - Use case guidance (vertical for interactive, horizontal for papers) The documentation explains that vertical layouts display cardinality horizontally (on the left) and set sizes vertically (on top), making them ideal for interactive plots that can be scrolled.
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.