fix: avoid cast tv wakeups

Author: edmundmiller

modules/services/hass/_domains/conversation.nix

@@ -182,8 +182,7 @@ _: {
         speech.text = "Turning on the TV.";
         action = [
           {
-            action = "media_player.turn_on";
-            target.entity_id = "media_player.tv";
+            action = "script.tv_on";
           }
         ];
       };

modules/services/hass/_domains/tv.nix

@@ -3,10 +3,12 @@
 let
   inherit (import ../_lib.nix) ensureEnabled;
 
+  tvEntity = "media_player.living_room";
+
   # --- Helper functions ---
   tvAction = action: {
     inherit action;
-    target.entity_id = "media_player.tv";
+    target.entity_id = tvEntity;
   };
 
   tvOn = tvAction "media_player.turn_on";
@@ -66,7 +68,7 @@ in
         id = "tv_idle_auto_off";
         trigger = {
           platform = "state";
-          entity_id = "media_player.tv";
+          entity_id = tvEntity;
           to = "idle";
           "for".hours = 2;
         };
@@ -136,7 +138,7 @@ in
         id = "count_tv_sessions";
         trigger = {
           platform = "state";
-          entity_id = "media_player.tv";
+          entity_id = tvEntity;
           to = "playing";
         };
         action = [

modules/services/hass/_tests/eval-automations.nix

@@ -21,6 +21,7 @@ let
   haConfig = nixosConfig.config.services.home-assistant.config;
   automations = haConfig.automation;
   scenes = haConfig.scene;
+  scripts = haConfig.script;
 
   findAutomation =
     id:
@@ -82,6 +83,8 @@ let
   hasActionVariable =
     actions: variableName: any (a: a ? variables && builtins.hasAttr variableName a.variables) actions;
 
+  hasTargetEntity = actions: entityId: any (a: (a.target.entity_id or null) == entityId) actions;
+
   hasTimeGuard =
     conditions: target:
     any (c: (c.condition or null) == "time" && (c.after or null) == target) conditions;
@@ -142,6 +145,7 @@ let
   alDaytimeSleepCorrection = findAutomation "al_daytime_sleep_correction";
   entranceOccupancyNightLight = findAutomation "entrance_occupancy_night_light";
   arrivalFlashWallLamp = findAutomation "arrival_flash_wall_lamp";
+  tvOnScript = scripts.tv_on or null;
 
   # Must stay removed
   goodMorningBothAwake = findAutomation "good_morning_both_awake";
@@ -222,6 +226,14 @@ let
       test = syncIphoneAlarm8sleep != null && (syncIphoneAlarm8sleep.initial_state or null) == false;
       msg = "automation 'sync_iphone_alarm_8sleep' should remain present but declaratively disabled until an iOS alarm source exists";
     }
+    {
+      test =
+        tvOnScript != null
+        && hasActionCall (toList (tvOnScript.sequence or [ ])) "media_player.turn_on"
+        && hasTargetEntity (toList (tvOnScript.sequence or [ ])) "media_player.living_room"
+        && !(hasTargetEntity (toList (tvOnScript.sequence or [ ])) "media_player.tv");
+      msg = "script.tv_on must target Living Room Apple TV, not Cast media_player.tv";
+    }
     {
       test = sleepFocusOffEdmund != null;
       msg = "automation 'sleep_focus_off_stop_edmund' missing";