Use maybe_unused attribute instead of casting variables to void

Author: edo9300

gframe/CGUICustomTabControl/CGUICustomTabControl.cpp

@@ -802,7 +802,7 @@ s32 CGUICustomTabControl::getTabIndex(const IGUIElement *tab) const
 
 //! Removes a child.
 void CGUICustomTabControl::removeChild(IGUIElement* child) {
-	bool isTab = false;
+	[[maybe_unused]] bool isTab = false;
 
 	u32 i = 0;
 	// check if it is a tab
@@ -814,7 +814,6 @@ void CGUICustomTabControl::removeChild(IGUIElement* child) {
 		} else
 			++i;
 	}
-	(void)isTab;
 
 #if !(IRRLICHT_VERSION_MAJOR==1 && IRRLICHT_VERSION_MINOR==9)
 	// reassign numbers

gframe/bufferio.h

@@ -50,8 +50,7 @@ class BufferIO {
 private:
 	static constexpr inline bool isUtf16 = sizeof(wchar_t) == 2;
 	template<bool check_output_size = false>
-	static int EncodeUTF8internal(epro::wstringview source, char* out, size_t size = 0) {
-		(void)size;
+	static int EncodeUTF8internal(epro::wstringview source, char* out, [[maybe_unused]] size_t size = 0) {
 		char* pstr = out;
 		auto GetNextSize = [](auto cur) -> size_t {
 			if(cur < 0x80u)
@@ -112,8 +111,7 @@ class BufferIO {
 		return static_cast<int>(out - pstr);
 	}
 	template<bool check_output_size = false>
-	static int DecodeUTF8internal(epro::stringview source, wchar_t* out, size_t size = 0) {
-		(void)size;
+	static int DecodeUTF8internal(epro::stringview source, wchar_t* out, [[maybe_unused]] size_t size = 0) {
 		wchar_t* pstr = out;
 		while(!source.empty()) {
 			auto first_codepoint = static_cast<unsigned char>(*source.begin());

gframe/client_updater.cpp

@@ -45,9 +45,7 @@ struct Payload {
 };
 
 template<typename off_type>
-static int progress_callback(void* ptr, off_type TotalToDownload, off_type NowDownloaded, off_type TotalToUpload, off_type NowUploaded) {
-	(void)TotalToUpload;
-	(void)NowUploaded;
+static int progress_callback(void* ptr, off_type TotalToDownload, [[maybe_unused]] off_type NowDownloaded, [[maybe_unused]] off_type TotalToUpload, off_type NowUploaded) {
 	Payload* payload = static_cast<Payload*>(ptr);
 	if(payload && payload->callback) {
 		int percentage = 0;

gframe/deck_manager.cpp

@@ -578,8 +578,7 @@ bool DeckManager::ImportDeckBase64Omega(Deck& deck, epro::wstringview buffer) {
 	LoadDeckFromBuffer(deck, reinterpret_cast<uint32_t*>(out_buf + 2), mainc, sidec);
 	return true;
 }
-bool DeckManager::DeleteDeck(Deck& deck, epro::path_stringview name) {
-	(void)deck;
+bool DeckManager::DeleteDeck([[maybe_unused]] Deck& deck, epro::path_stringview name) {
 	return Utils::FileDelete(epro::format(EPRO_TEXT("./deck/{}.ydk"), name));
 }
 bool DeckManager::RenameDeck(epro::path_stringview oldname, epro::path_stringview newname) {

gframe/discord_wrapper.cpp

@@ -48,8 +48,7 @@ bool DiscordWrapper::Initialize() {
 #endif //DISCORD_APP_ID
 }
 
-void DiscordWrapper::UpdatePresence(PresenceType type) {
-	(void)type;
+void DiscordWrapper::UpdatePresence([[maybe_unused]] PresenceType type) {
 #ifdef DISCORD_APP_ID
 	auto CreateSecret = [&secret_buf=secret_buf](bool update) {
 		if(update) {

gframe/duelclient.cpp

@@ -146,10 +146,7 @@ bool DuelClient::StartClient(const epro::Address& ip, uint16_t port, uint32_t ga
 	client_thread = epro::thread(ClientThread);
 	return true;
 }
-void DuelClient::ConnectTimeout(evutil_socket_t fd, short events, void* arg) {
-	(void)fd;
-	(void)events;
-	(void)arg;
+void DuelClient::ConnectTimeout([[maybe_unused]] evutil_socket_t fd, [[maybe_unused]] short events, [[maybe_unused]] void* arg) {
 	if(connect_state & 0x7)
 		return;
 	if(!is_closing) {
@@ -192,8 +189,7 @@ void DuelClient::StopClient(bool is_exiting) {
 		client_thread.join();
 	mainGame->frameSignal.SetNoWait(false);
 }
-void DuelClient::ClientRead(bufferevent* bev, void* ctx) {
-	(void)ctx;
+void DuelClient::ClientRead(bufferevent* bev, [[maybe_unused]] void* ctx) {
 	evbuffer* input = bufferevent_get_input(bev);
 	size_t len = evbuffer_get_length(input);
 	uint16_t packet_len = 0;
@@ -214,8 +210,7 @@ void DuelClient::ClientRead(bufferevent* bev, void* ctx) {
 
 #define INTERNAL_HANDLE_CONNECTION_END 0
 
-void DuelClient::ClientEvent(bufferevent *bev, short events, void *ctx) {
-	(void)bev;
+void DuelClient::ClientEvent([[maybe_unused]] bufferevent *bev, short events, void *ctx) {
 	if (events & BEV_EVENT_CONNECTED) {
 		bool create_game = (size_t)ctx != 0;
 		CTOS_PlayerInfo cspi;

gframe/generic_duel.cpp

@@ -788,9 +788,7 @@ void GenericDuel::Surrender(DuelPlayer* dp) {
 	}
 }
 #define SEND(to) NetServer::SendCoreUtilsPacketToPlayer(to, STOC_GAME_MSG, packet)
-void GenericDuel::BeforeParsing(const CoreUtils::Packet& packet, int& return_value, bool& record, bool& record_last) {
-	(void)return_value;
-	(void)record;
+void GenericDuel::BeforeParsing(const CoreUtils::Packet& packet, [[maybe_unused]] int& return_value, [[maybe_unused]] bool& record, bool& record_last) {
 	const auto* pbuf = packet.data();
 	switch(packet.message) {
 	case MSG_SELECT_BATTLECMD:
@@ -824,8 +822,7 @@ void GenericDuel::BeforeParsing(const CoreUtils::Packet& packet, int& return_val
 		return;
 	}
 }
-void GenericDuel::Sending(CoreUtils::Packet& packet, int& return_value, bool& record, bool& record_last) {
-	(void)record_last;
+void GenericDuel::Sending(CoreUtils::Packet& packet, int& return_value, bool& record, [[maybe_unused]] bool& record_last) {
 	uint8_t& message = packet.message;
 	uint32_t type, count;
 	uint8_t player;
@@ -1118,10 +1115,7 @@ void GenericDuel::Sending(CoreUtils::Packet& packet, int& return_value, bool& re
 }
 #undef SEND
 
-void GenericDuel::AfterParsing(const CoreUtils::Packet& packet, int& return_value, bool& record, bool& record_last) {
-	(void)return_value;
-	(void)record;
-	(void)record_last;
+void GenericDuel::AfterParsing(const CoreUtils::Packet& packet, [[maybe_unused]] int& return_value, [[maybe_unused]] bool& record, [[maybe_unused]] bool& record_last) {
 	const auto message = packet.message;
 	int player;
 	const auto* pbuf = packet.data();
@@ -1322,8 +1316,7 @@ void GenericDuel::WaitforResponse(uint8_t playerid) {
 	}
 	cur_player[playerid]->state = CTOS_RESPONSE;
 }
-void GenericDuel::TimeConfirm(DuelPlayer* dp) {
-	(void)dp;
+void GenericDuel::TimeConfirm([[maybe_unused]] DuelPlayer* dp) {
 	return;
 	/*if(host_info.time_limit == 0)
 		return;
@@ -1415,9 +1408,7 @@ void GenericDuel::PseudoRefreshDeck(uint8_t player, uint32_t flag) {
 	memcpy(&buffer[3], buff, len);
 	replay_stream.emplace_back(buffer.data(), buffer.size() - 1);
 }
-void GenericDuel::GenericTimer(evutil_socket_t fd, short events, void* arg) {
-	(void)fd;
-	(void)events;
+void GenericDuel::GenericTimer([[maybe_unused]] evutil_socket_t fd, [[maybe_unused]] short events, void* arg) {
 	GenericDuel* sd = static_cast<GenericDuel*>(arg);
 	if(sd->last_response < 2 && sd->cur_player[sd->last_response]->state == CTOS_RESPONSE) {
 		if(sd->grace_period >= 0) {

gframe/ireadfile_sqlite.cpp

@@ -39,8 +39,7 @@ int fileFileSize(sqlite3_file* file, sqlite3_int64* size) {
 	return SQLITE_OK;
 }
 
-int fileCheckReservedLock(sqlite3_file* file, int* result) {
-	(void)file;
+int fileCheckReservedLock([[maybe_unused]] sqlite3_file* file, int* result) {
 	*result = 0;
 	return SQLITE_OK;
 }
@@ -63,9 +62,7 @@ constexpr sqlite3_io_methods iomethods{
 
 //===========================================================================
 
-int vfsOpen(sqlite3_vfs* vfs, const char* path, sqlite3_file* file, int flags, int* outflags) {
-	(void)vfs;
-
+int vfsOpen([[maybe_unused]] sqlite3_vfs* vfs, const char* path, sqlite3_file* file, int flags, int* outflags) {
 	if(!(SQLITE_OPEN_READONLY & flags))
 		return SQLITE_ERROR;
 
@@ -82,16 +79,12 @@ int vfsOpen(sqlite3_vfs* vfs, const char* path, sqlite3_file* file, int flags, i
 	return SQLITE_OK;
 }
 
-int vfsAccess(sqlite3_vfs* vfs, const char* path, int flags, int* result) {
-	(void)vfs;
-	(void)path;
-	(void)flags;
+int vfsAccess([[maybe_unused]] sqlite3_vfs* vfs, [[maybe_unused]] const char* path, [[maybe_unused]] int flags, int* result) {
 	*result = 0;
 	return SQLITE_OK;
 }
 
-int vfsFullPathname(sqlite3_vfs* vfs, const char* path, int len, char* fullpath) {
-	(void)vfs;
+int vfsFullPathname([[maybe_unused]] sqlite3_vfs* vfs, const char* path, int len, char* fullpath) {
 	sqlite3_snprintf(len, fullpath, "%s", path);
 	return SQLITE_OK;
 }

gframe/joystick_wrapper.cpp

@@ -1,7 +1,6 @@
 #include "joystick_wrapper.h"
 #ifndef YGOPRO_USE_JOYSTICK
-JWrapper::JWrapper(irr::IrrlichtDevice* _device) {
-	(void)_device;
+JWrapper::JWrapper([[maybe_unused]] irr::IrrlichtDevice* _device) {
 }
 
 JWrapper::~JWrapper() {

gframe/netserver.cpp

@@ -203,9 +203,7 @@ void NetServer::StopListen() {
 	evconnlistener_disable(listener);
 	StopBroadcast();
 }
-void NetServer::BroadcastEvent(evutil_socket_t fd, short events, void* arg) {
-	(void)events;
-	(void)arg;
+void NetServer::BroadcastEvent(evutil_socket_t fd, [[maybe_unused]] short events, [[maybe_unused]] void* arg) {
 	sockaddr_storage bc_addr;
 	ev_socklen_t sz = sizeof(bc_addr);
 	char buf[256];
@@ -227,11 +225,8 @@ void NetServer::BroadcastEvent(evutil_socket_t fd, short events, void* arg) {
 		sendto(fd, (const char*)&hp, sizeof(HostPacket), 0, (sockaddr*)&bc_addr, bc_addr.ss_family == AF_INET ? sizeof(sockaddr_in) : sizeof(sockaddr_in6));
 	}
 }
-void NetServer::ServerAccept(evconnlistener* bev_listener, evutil_socket_t fd, sockaddr* address, int socklen, void* ctx) {
-	(void)bev_listener;
-	(void)address;
-	(void)socklen;
-	(void)ctx;
+void NetServer::ServerAccept([[maybe_unused]] evconnlistener* bev_listener, evutil_socket_t fd, [[maybe_unused]] sockaddr* address,
+							 [[maybe_unused]] int socklen, [[maybe_unused]] void* ctx) {
 	bufferevent* bev = bufferevent_socket_new(net_evbase, fd, BEV_OPT_CLOSE_ON_FREE);
 	DuelPlayer dp;
 	dp.name[0] = 0;
@@ -241,13 +236,10 @@ void NetServer::ServerAccept(evconnlistener* bev_listener, evutil_socket_t fd, s
 	bufferevent_setcb(bev, ServerEchoRead, nullptr, ServerEchoEvent, nullptr);
 	bufferevent_enable(bev, EV_READ);
 }
-void NetServer::ServerAcceptError(evconnlistener* bev_listener, void* ctx) {
-	(void)bev_listener;
-	(void)ctx;
+void NetServer::ServerAcceptError([[maybe_unused]] evconnlistener* bev_listener, [[maybe_unused]] void* ctx) {
 	event_base_loopexit(net_evbase, 0);
 }
-void NetServer::ServerEchoRead(bufferevent *bev, void *ctx) {
-	(void)ctx;
+void NetServer::ServerEchoRead(bufferevent *bev, [[maybe_unused]] void *ctx) {
 	evbuffer* input = bufferevent_get_input(bev);
 	size_t len = evbuffer_get_length(input);
 	uint16_t packet_len = 0;
@@ -263,8 +255,7 @@ void NetServer::ServerEchoRead(bufferevent *bev, void *ctx) {
 		len -= packet_len + 2;
 	}
 }
-void NetServer::ServerEchoEvent(bufferevent* bev, short events, void* ctx) {
-	(void)ctx;
+void NetServer::ServerEchoEvent(bufferevent* bev, short events, [[maybe_unused]] void* ctx) {
 	if (events & (BEV_EVENT_EOF | BEV_EVENT_ERROR)) {
 		DuelPlayer* dp = &users[bev];
 		DuelMode* dm = dp->game;

gframe/repo_manager.cpp

@@ -364,8 +364,7 @@ int RepoManager::FetchCb(const git_indexer_progress* stats, void* payload) {
 	return pl->rm->fetchReturnValue;
 }
 
-void RepoManager::CheckoutCb(const char* path, size_t completed_steps, size_t total_steps, void* payload) {
-	(void)path;
+void RepoManager::CheckoutCb([[maybe_unused]] const char* path, size_t completed_steps, size_t total_steps, void* payload) {
 	int percent;
 	if(total_steps == 0)
 		percent = CHECKOUT_PERCENTAGE;

gframe/utils.cpp

@@ -70,8 +70,7 @@ struct THREADNAME_INFO {
 	DWORD dwFlags; // Reserved for future use, must be zero.
 };
 
-LONG NTAPI PvectoredExceptionHandler(EXCEPTION_POINTERS* ExceptionInfo) {
-	(void)ExceptionInfo;
+LONG NTAPI PvectoredExceptionHandler([[maybe_unused]] EXCEPTION_POINTERS* ExceptionInfo) {
 	return EXCEPTION_CONTINUE_EXECUTION;
 }
 
@@ -173,8 +172,7 @@ namespace ygo {
 
 	RNG::SplitMix64 Utils::generator(std::chrono::high_resolution_clock::now().time_since_epoch().count());
 
-	void Utils::InternalSetThreadName(const char* name, const wchar_t* wname) {
-		(void)wname;
+	void Utils::InternalSetThreadName(const char* name, [[maybe_unused]] const wchar_t* wname) {
 #if EDOPRO_WINDOWS
 		NameThread(name, wname);
 #elif EDOPRO_LINUX_KERNEL
@@ -276,7 +274,7 @@ namespace ygo {
 		return SetLastErrorStringIfFailed(mkdir(path.data(), 0777) == 0 || errno == EEXIST);
 #endif
 	}
-	bool Utils::FileCopyFD(int source, int destination) {
+	bool Utils::FileCopyFD([[maybe_unused]] int source, [[maybe_unused]] int destination) {
 #if EDOPRO_LINUX_KERNEL
 		off_t bytesCopied = 0;
 		Stat fileinfo{};
@@ -286,8 +284,6 @@ namespace ygo {
 #elif EDOPRO_APPLE
 		return SetLastErrorStringIfFailed(fcopyfile(source, destination, 0, COPYFILE_ALL) == 0);
 #else
-		(void)source;
-		(void)destination;
 		return false;
 #endif
 	}
@@ -769,15 +765,14 @@ namespace ygo {
 		chmod(path.data(), fileStat.st_mode | S_IXUSR | S_IXGRP | S_IXOTH);
 #endif
 		{
-			const auto* path_cstr = path.data();
+			[[maybe_unused]] const auto* path_cstr = path.data();
 			const auto& workdir = GetWorkingDirectory();
 			const auto* workdir_cstr = workdir.data();
 			auto pid = vfork();
 			if(pid == 0) {
 #if EDOPRO_LINUX
 				execl(path_cstr, path_cstr, "-C", workdir_cstr, "-l", nullptr);
 #else
-				(void)path_cstr;
 				execlp("open", "open", "-b", "io.github.edo9300.ygoprodll", "--args", "-C", workdir_cstr, "-l", nullptr);
 #endif
 				_exit(EXIT_FAILURE);

gframe/utils_gui.cpp

@@ -62,8 +62,7 @@ static HWND GetWindowHandle(irr::video::IVideoDriver* driver) {
 }
 #endif
 
-static inline irr::video::E_DRIVER_TYPE getDefaultDriver(irr::E_DEVICE_TYPE device_type) {
-	(void)device_type;
+static inline irr::video::E_DRIVER_TYPE getDefaultDriver([[maybe_unused]] irr::E_DEVICE_TYPE device_type) {
 #if EDOPRO_ANDROID
 	return irr::video::EDT_OGLES2;
 #elif EDOPRO_IOS
@@ -211,8 +210,7 @@ bool GUIUtils::TakeScreenshot(std::shared_ptr<irr::IrrlichtDevice>& device) {
 	return written;
 }
 #if (IRRLICHT_VERSION_MAJOR==1 && IRRLICHT_VERSION_MINOR==9)
-void GUIUtils::ToggleFullscreen(std::shared_ptr<irr::IrrlichtDevice>& device, bool& fullscreen) {
-	(void)fullscreen;
+void GUIUtils::ToggleFullscreen(std::shared_ptr<irr::IrrlichtDevice>& device, [[maybe_unused]] bool& fullscreen) {
 #if EDOPRO_MACOS
 	EDOPRO_ToggleFullScreen();
 #elif EDOPRO_WINDOWS || EDOPRO_LINUX
@@ -229,8 +227,7 @@ static BOOL CALLBACK callback(HMONITOR hMon, HDC hdc, LPRECT lprcMonitor, LPARAM
 	return TRUE;
 }
 #endif
-void GUIUtils::ToggleFullscreen(std::shared_ptr<irr::IrrlichtDevice>& device, bool& fullscreen) {
-	(void)fullscreen;
+void GUIUtils::ToggleFullscreen(std::shared_ptr<irr::IrrlichtDevice>& device, [[maybe_unused]] bool& fullscreen) {
 #if EDOPRO_MACOS
 	EDOPRO_ToggleFullScreen();
 #elif EDOPRO_WINDOWS