Skip to content

Commit e4cb501

Browse files
committed
Fix read-only error triggered by Pandas 2.3 Copy-on-Write
1 parent d6b08ef commit e4cb501

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/pybroker/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,5 +379,5 @@ def get_unique_sorted_dates(col: pd.Series) -> Sequence[np.datetime64]:
379379
# TODO: Remove after Pandas 1.0 is no longer supported.
380380
if hasattr(result, "to_numpy"):
381381
result = result.to_numpy()
382-
result.sort()
382+
result = np.sort(result)
383383
return result

src/pybroker/strategy.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1327,8 +1327,7 @@ def _run_walkforward(
13271327
DataCol.DATE.value
13281328
].values
13291329
if len(sym_dates):
1330-
sym_dates.sort()
1331-
exit_dates[sym] = sym_dates[-1]
1330+
exit_dates[sym] = sym_dates.max()
13321331
signals: dict[str, pd.DataFrame] = {}
13331332
for train_idx, test_idx in self.walkforward_split(
13341333
df=df,

0 commit comments

Comments
 (0)