Fix dashboard crash when localStorage is unavailable#10
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Edward Thompson <edwardlthompson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Browsers that throw on
localStorageaccess (for example restricted/private profiles, blocked site storage, or quota/security failures) could successfully fetch and render a snapshot, then throw during post-render persistence. The outerloadSnapshotcatch treated that persistence failure as a load failure, calledshowError(), and cleared the populated qualified table, leaving the dashboard unusable despite valid data.Root cause
docs/dashboard/app.jsmixed critical render/load logic with directlocalStorage.getItem/setItem/removeItemcalls. Several of those calls run during startup and afterrender(data), so a storage exception could abort the page or unwind into the snapshot load error handler.Fix
Added small safe localStorage helpers and routed dashboard storage reads/writes/removals through them. Storage-backed preferences and notification baselines now degrade gracefully while valid snapshot rendering remains intact.
Validation
node --check docs/dashboard/app.jswindow.localStoragethrowSecurityError: rendered 41 table rows, empty error banner, populated snapshot metadata.http://127.0.0.1:8765/dashboard/?api=../qualified_public_snapshot.jsonconfirmed populated table rows and no visible error banner; saved video artifactdashboard_storage_fix_manual_walkthrough.mp4.