Fix provider fallback circuit on symbol-scoped errors#12
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Edward Thompson <edwardlthompson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Repeated per-symbol fallback HTTP errors (for example Polygon 404 or CMC 400 for unknown symbols) were counted as provider-wide circuit failures. During a scan/backtest, a handful of bad symbols could open the shared fallback circuit and silently skip Polygon/CMC OHLCV requests for unrelated later symbols, causing missed qualifications or incomplete backtest/snapshot data.
Root cause
PriceHistoryFallbackClient._polygon_http_getand_cmc_http_getrecorded every non-200 response as a circuit failure after retries. The circuit is shared by the fallback client, so symbol/request validation errors accumulated globally.Fix
Only record circuit failures for provider-wide conditions: timeouts/exceptions, 408, exhausted 429, auth/global access failures, and 5xx responses. Symbol-scoped 4xx responses continue to return to callers without opening the provider circuit.
Validation
python3 -m pytest tests/test_price_history_fallback_circuit.py tests/test_provider_rate_limit.pypython3 -m py_compile api/price_history_fallback.py utils/provider_circuit.py