Align Capabilities and ServerVersion exception behaviour across derived classes

Author: edwardneal

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionClosed.cs

@@ -22,6 +22,8 @@ protected DbConnectionClosed(ConnectionState state, bool hidePassword, bool allo
 
         public override string ServerVersion => throw ADP.ClosedConnectionError();
 
+        public override ConnectionCapabilities Capabilities => throw ADP.ClosedConnectionError();
+
         protected override void Activate(System.Transactions.Transaction transaction) => throw ADP.ClosedConnectionError();
 
         public override DbTransaction BeginTransaction(IsolationLevel il) => throw ADP.ClosedConnectionError();

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs

@@ -167,8 +167,7 @@ internal bool IsInPool
 
         public abstract string ServerVersion { get; }
 
-        public virtual ConnectionCapabilities Capabilities =>
-            null;
+        public virtual ConnectionCapabilities Capabilities => null;
 
         // this should be abstract but until it is added to all the providers virtual will have to do RickFe
         public virtual string ServerVersionNormalized

src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/ChannelDbConnectionPoolTest.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
@@ -965,6 +965,8 @@ internal class StubDbConnectionInternal : DbConnectionInternal
             #region Not Implemented Members
             public override string ServerVersion => throw new NotImplementedException();
 
+            public override ConnectionCapabilities Capabilities => throw new NotImplementedException();
+
             public override DbTransaction BeginTransaction(System.Data.IsolationLevel il)
             {
                 throw new NotImplementedException();

src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/ConnectionPoolSlotsTest.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
@@ -24,6 +24,8 @@ public MockDbConnectionInternal() : base(ConnectionState.Open, true, false) { }
 
             public override string ServerVersion => "Mock Server 1.0";
 
+            public override ConnectionCapabilities Capabilities => new();
+
             public override DbTransaction BeginTransaction(System.Data.IsolationLevel il)
             {
                 throw new NotImplementedException();

src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/IdleConnectionChannelTest.cs

@@ -7,6 +7,7 @@
 using System.Threading;
 using System.Threading.Tasks;
 using System.Transactions;
+using Microsoft.Data.Common;
 using Microsoft.Data.ProviderBase;
 using Microsoft.Data.SqlClient.ConnectionPool;
 using Xunit;
@@ -230,6 +231,8 @@ private class StubDbConnectionInternal : DbConnectionInternal
         {
             public override string ServerVersion => throw new NotImplementedException();
 
+            public override ConnectionCapabilities Capabilities => throw new NotImplementedException();
+
             public override DbTransaction BeginTransaction(System.Data.IsolationLevel il)
                 => throw new NotImplementedException();
 

src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/TransactedConnectionPoolTest.cs

@@ -713,6 +713,8 @@ internal class MockDbConnectionInternal : DbConnectionInternal
 
         public override string ServerVersion => "Mock";
 
+        public override ConnectionCapabilities Capabilities => new();
+
         public override DbTransaction BeginTransaction(System.Data.IsolationLevel il)
         {
             throw new NotImplementedException();

src/Microsoft.Data.SqlClient/tests/UnitTests/ConnectionPool/WaitHandleDbConnectionPoolTransactionTest.cs

@@ -918,6 +918,8 @@ internal class MockDbConnectionInternal : DbConnectionInternal
 
         public override string ServerVersion => "Mock";
 
+        public override ConnectionCapabilities Capabilities => new();
+
         public override DbTransaction BeginTransaction(System.Data.IsolationLevel il)
         {
             throw new NotImplementedException();