avoid redundant exception type checks (dotnet#4100)

Author: SimonCropp

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ManagedSni/SniTcpHandle.netcore.cs

@@ -221,8 +221,10 @@ public SniTcpHandle(
                                     {
                                         throw;
                                     }
-                                    if (exRetry is SocketException || exRetry is ArgumentNullException
-                                        || exRetry is ArgumentException || exRetry is ArgumentOutOfRangeException || exRetry is AggregateException)
+                                    if (exRetry is
+                                        SocketException or
+                                        ArgumentException or
+                                        AggregateException)
                                     {
                                         SqlClientEventSource.Log.TrySNITraceEvent(nameof(SniTcpHandle), EventType.INFO, "Connection Id {0}, Retrying exception {1}", args0: _connectionId, args1: exRetry?.Message);
                                         if (parallel)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

@@ -188,17 +188,17 @@ static SqlAuthenticationProviderManager()
             // simply have no default and the app must provide one if they
             // attempt to use Active Directory authentication.
             catch (Exception ex)
-            when (ex is ArgumentNullException ||
-                  ex is ArgumentException ||
-                  ex is BadImageFormatException ||
-                  ex is FileLoadException ||
-                  ex is FileNotFoundException ||
-                  ex is MemberAccessException ||
-                  ex is MethodAccessException ||
-                  ex is MissingMethodException ||
-                  ex is NotSupportedException ||
-                  ex is TargetInvocationException ||
-                  ex is TypeLoadException)
+            when (ex is
+                      ArgumentException or
+                      BadImageFormatException or
+                      FileLoadException or
+                      FileNotFoundException or
+                      MemberAccessException or
+                      MethodAccessException or
+                      MissingMethodException or
+                      NotSupportedException or
+                      TargetInvocationException or
+                      TypeLoadException)
             {
                 SqlClientEventSource.Log.TryTraceEvent(
                     nameof(SqlAuthenticationProviderManager) +

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlQueryMetadataCache.cs

@@ -129,7 +129,7 @@ internal bool GetQueryMetadataIfExists(SqlCommand sqlCommand)
                         InvalidateCacheEntry(sqlCommand);
 
                         // If we get one of the expected exceptions, just fail the cache lookup, otherwise throw.
-                        if (ex is SqlException || ex is ArgumentException || ex is ArgumentNullException)
+                        if (ex is SqlException or ArgumentException)
                         {
                             foreach (SqlParameter paramToCleanup in sqlCommand.Parameters)
                             {