Skip to content

Commit b77c202

Browse files
authored
Removed PackSqlServer from BuildAllConfigurations target (dotnet#3991)
1 parent e8be52d commit b77c202

3 files changed

Lines changed: 11 additions & 11 deletions

File tree

BUILDGUIDE.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ The following build targets are defined in `build.proj`:
7272
|`BuildNetCore`|Builds the .NET driver for all target frameworks.|
7373
|`BuildNetCoreAllOS`|Builds the .NET driver for all target frameworks and operating systems.|
7474
|`BuildNetFx`|Builds the .NET Framework driver for all target frameworks.|
75+
|`BuildSqlClient`|Build the driver for all target frameworks.|
7576
|`Clean`|Cleans all generated files.|
7677
|`PackAbstractions`|Pack the Abstractions NuGet package into `packages/`. Requires `BuildAbstractions` first.|
7778
|`PackAzure`|Pack the Azure NuGet package into `packages/`. Requires `BuildAzure` first.|
@@ -192,15 +193,13 @@ packages in the root packages/ directory, and will be automatically searched by
192193
Then, you can specify `Package` references be used, for example:
193194

194195
```bash
195-
dotnet build -t:BuildLogging
196-
dotnet build -t:PackLogging
197-
dotnet build -t:BuildAbstractions -p:ReferenceType=Package
198-
dotnet build -t:PackAbstractions -p:ReferenceType=Package
199-
dotnet build -t:BuildAzure -p:ReferenceType=Package
200-
dotnet build -t:PackAzure -p:ReferenceType=Package
201-
dotnet build -t:BuildAll -p:ReferenceType=Package
202-
dotnet build -t:BuildAKVNetCore -p:ReferenceType=Package
196+
dotnet build -t:BuildLogging,PackLogging
197+
dotnet build -t:BuildSqlServer,PackSqlServer
198+
dotnet build -t:BuildAbstractions,PackAbstractions -p:ReferenceType=Package
199+
dotnet build -t:BuildAzure,PackAzure -p:ReferenceType=Package
200+
dotnet build -t:BuildSqlClient -p:ReferenceType=Package
203201
dotnet build -t:GenerateMdsPackage
202+
dotnet build -t:BuildAKVNetCore -p:ReferenceType=Package
204203
dotnet build -t:GenerateAkvPackage
205204
```
206205

build.proj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,9 @@
9595

9696
<!-- Top Level Build targets -->
9797
<Target Name="Restore" DependsOnTargets="RestoreNetCore;RestoreNetFx" />
98-
<Target Name="BuildAll" DependsOnTargets="BuildNetFx;BuildNetCore;BuildNetStandard;BuildLogging;BuildAzure" />
99-
<Target Name="BuildAllConfigurations" DependsOnTargets="Restore;BuildTools;BuildSqlServer;BuildNetFx;BuildNetCoreAllOS;BuildNetStandard;BuildLogging;BuildSqlServer;PackSqlServer;GenerateMdsPackage" />
98+
<Target Name="BuildSqlClient" DependsOnTargets="BuildSqlServer;BuildLogging;BuildAbstractions;BuildNetFx;BuildNetCore;BuildNetStandard" />
99+
<!-- TODO: This doesn't really build everything; just the SqlClient driver and its NuGet package. -->
100+
<Target Name="BuildAllConfigurations" DependsOnTargets="Restore;BuildTools;BuildSqlServer;BuildLogging;BuildAbstractions;BuildNetFx;BuildNetCoreAllOS;BuildNetStandard;GenerateMdsPackage" />
100101

101102
<!-- SqlServer Targets -->
102103
<PropertyGroup>

eng/pipelines/common/templates/steps/ci-project-build-step.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ steps:
163163
projects: build.proj
164164
custom: msbuild
165165
arguments: >-
166-
-t:BuildAll
166+
-t:BuildSqlClient
167167
-p:ReferenceType=${{ parameters.referenceType }}
168168
-p:TestEnabled=true
169169
-p:GenerateNuget=false

0 commit comments

Comments
 (0)