Skip to content

Commit 43a58f9

Browse files
committed
Nitpics from @coderabbitai
1 parent 049f24b commit 43a58f9

File tree

5 files changed

+10
-11
lines changed

5 files changed

+10
-11
lines changed

docs/addon_climate.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,15 +230,15 @@ The thermostat's settings range from a minimum of `15°C` to a maximum of `22°C
230230
Furthermore, I have selected `18.3°C` as the default target temperature.
231231

232232
```yaml
233-
##### addon-configuration #####
233+
##### addon-configuration - start #####
234234
## addon_climate ##
235235
heater_relay: "1" # Use relay 1
236236
temp_min: "15"
237237
temp_max: "22"
238238
heat_deadband: "0.1"
239239
heat_overrun: "0.1"
240-
241-
##### CHANGE ME END #####
240+
##### addon-configuration - end #####
241+
242242
climate:
243243
- id: !extend thermostat_embedded
244244
preset:

docs/different_version.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ Take note of the branch (`dev`, `beta`, or `main`) or version name exactly as it
6363
<!-- markdownlint-enable MD028 -->
6464
6565
### For Nextion TFT Component
66+
67+
> [!NOTE]
68+
> The TFT version is automatically matched to your ESPHome version—no manual version selection is required.
69+
6670
1. Go to your device's page under **Settings** > **Devices & services** > **ESPHome**.
6771
2. On the **Configuration** group, press **Update TFT display** and wait for the upload to complete. The system will automatically find the right TFT file for the ESPHome version you are running.
6872

esphome/nspanel_esphome_addon_upload_tft.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ script:
9090
return;
9191
}
9292
93-
// Only proceed when std TFT is selected (indices 2+)
93+
// Only proceed when a standard TFT is selected (indices 1+)
9494
if (tft_file_model->active_index().value_or(0) == 0) {
9595
ESP_LOGV("${TAG_UPLOAD_TFT}", "No standard TFT selected");
9696
return;

esphome/nspanel_esphome_api.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,19 +128,14 @@ api:
128128
129129
// Extract component information using helper function
130130
const NextionComponent component = extractNextionComponent(component_id, resolved_page);
131-
if (std::string(component.page) != current_page->state) {
132-
ESP_LOGW("${TAG_API}", "Skipping off-page component (%s vs %s)",
133-
component.page, current_page->state.c_str());
134-
continue;
135-
}
136-
const char* target_id = component.component_id;
137131
const std::string component_page = component.page;
138132
if (component_page != resolved_page) {
139133
ESP_LOGW("${TAG_API}", "Skipping component on non-current page (%s vs %s)",
140134
component_page.c_str(), resolved_page.c_str());
141135
continue;
142136
}
143137
138+
const char* target_id = component.component_id;
144139
ESP_LOGV("${TAG_API}", " target: %s", target_id);
145140
146141
// Apply visibility change

prebuilt/wall_display.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ dashboard_import:
2828

2929
esphome:
3030
project:
31-
name: esphome.Wall_Display
31+
name: edwardtfn.Wall_Display
3232
platformio_options:
3333
build_flags:
3434
- -D NSPANEL_EASY_PREBUILT_WALL_DISPLAY

0 commit comments

Comments
 (0)