Skip to content

Commit 29f57c7

Browse files
authored
Merge pull request #101 from eecs485staff/fix/hide-vertical-scrollbars
Hide vertical scrollbars in Sidebar
2 parents 264be76 + 1ce50c6 commit 29f57c7

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.4.0
1+
1.4.1.d

_sass/spec/base.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,14 @@ $Z_INDEX_SIDEBAR: 4;
118118
&-item {
119119
// Prevent header items from ending too near the border of the Sidebar
120120
padding-right: 1em;
121+
121122
// If a heading item is too long and cannot be broken by the browser,
122123
// don't expand the width of the entire Sidebar. Instead, only make the
123124
// "offending" heading scrollable. (Kind-of-like how we currently treat
124125
// code-blocks and LaTeX on small screens.)
125-
overflow: auto;
126+
overflow-x: auto;
127+
// But don't show vertical scrollbars, they look jarring.
128+
overflow-y: hidden;
126129
}
127130

128131
&-h1 {

assets/v1.4/js/primer_spec_plugin.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo/long-headings.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ I copied the words from [Wikipedia](https://en.wikipedia.org/wiki/Longest_word_i
2222

2323
I copied this from [Wikipedia](https://en.wikipedia.org/wiki/Longest_word_in_English#Notable_long_words), and it looks like the editors added "soft hyphens" (U+00AD) to the string to allow it to break neatly in the Sidebar.
2424

25+
## `https://preview.seshrs.ml/preview/MyFancyOrganizationName/MySuperFancyRepoWhoseNameHasFortyEightCharacters`
26+
27+
Here's a long heading in an inline code block. And yes, that repo name actually _does_ have 48 characters!
28+
2529
## Bababadalgharaghtakamminarronnkonnbronntonnerronntuonnthunntrovarrhounawnskawntoohoohoordenenthurnuk
2630

2731
## It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness, it was the epoch of belief, it was the epoch of incredulity, it was the season of Light, it was the season of Darkness, it was the spring of hope, it was the winter of despair, we had everything before us, we had nothing before us, we were all going direct to Heaven, we were all going direct the other way—in short, the period was so far like the present period, that some of its noisiest authorities insisted on its being received, for good or for evil, in the superlative degree of comparison only.

0 commit comments

Comments
 (0)