Skip to content

Commit eecf9a9

Browse files
committed
Update ignore-list for link-checks in cibuild
I really dislike the solution in this commit, but I don't yet have a full understanding of why the link-check fails on GitHub Actions.
1 parent 37789da commit eecf9a9

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

.github/workflows/cibuild.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,6 @@ jobs:
3939
run: |
4040
./script/bootstrap
4141
42-
# Based on: https://github.com/gjtorikian/html-proofer/issues/376#issuecomment-332767999
43-
# And: https://github.com/actions/virtual-environments/issues/675#issuecomment-610483420
44-
- name: Fix HTMLProofer linkcheck
45-
run: |
46-
sudo sed -i 's/azure\.//' /etc/apt/sources.list
47-
sudo apt-get update
48-
sudo apt-get install -y -o Acquire::Retries=3 libcurl4-openssl-dev
49-
5042
- name: 🛠 Run CI tests
5143
run: |
5244
./script/cibuild

script/cibuild

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ bundle exec script/validate-html
99
# NOTE: The following will be removed after the master branch is removed.
1010
# On the master branch, check the HTML
1111
if [ "$(git rev-parse --abbrev-ref HEAD)" = 'master' ]; then
12-
bundle exec htmlproofer ./_site --check-html --url-ignore "/web.archive.org/,/localhost/"
12+
bundle exec htmlproofer ./_site --check-html --url-ignore "/web.archive.org/,/localhost/,/reactjs.org/,/docs.github.com/"
1313
fi
1414
# NOTE: End of section to delete after master is removed.
1515

1616
# On the main branch, check the HTML
1717
if [ "$(git rev-parse --abbrev-ref HEAD)" = 'main' ]; then
18-
bundle exec htmlproofer ./_site --check-html --url-ignore "/web.archive.org/,/localhost/"
18+
bundle exec htmlproofer ./_site --check-html --url-ignore "/web.archive.org/,/localhost/,/reactjs.org/,/docs.github.com/"
1919
fi
2020

2121
# Verify that all files are Prettified

0 commit comments

Comments
 (0)