Commit 9bef306
committed
Keep recoverable replay loads visually clean
Current logic replay files can contain a readable prefix when the
server is stopped before MessageWriter.Dispose closes the gzip stream.
Unity still records that diagnostic internally, but successful loads no
longer present it as a scary primary status line. The loaded status is
also shortened so the HUD does not wrap awkwardly after the team/player
numbers.
Constraint: Latest user-provided test replays are readable but end before a clean gzip/protobuf close.
Rejected: Treat recoverable replay tails as fatal | would break playback for current logic-group samples.
Rejected: Modify logic writer in this interface patch | user asked to inspect logic, and interface PRs should avoid logic/ changes.
Confidence: high
Scope-risk: narrow
Directive: Keep incomplete-tail diagnostics internal unless a load has no usable frames or truly fails.
Tested: Unity-Playback WebGL build succeeded.
Tested: Unity-Playback-WebGL.zip contents match playback/ directory by SHA256.
Tested: CDP WebGL regression loaded playback.thuaipb, mygame.thuaipb, and playback (1).thuaipb across repeated, cross-file, during-playback, URL, and blob scenarios with no playback-error or JS exception.
Tested: dotnet format whitespace verify for Unity-Playback scripts; git diff --check; origin/dev PR diff has zero logic/ files.
Not-tested: Manual OS file picker in the user's visible Chrome profile.1 parent 50aa1dd commit 9bef306
6 files changed
Lines changed: 5 additions & 10 deletions
File tree
- interface/Unity
- Unity-Playback/Assets/Scripts/Playback
- Unity-WebGL
- playback
- Build
Lines changed: 3 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
339 | | - | |
340 | | - | |
| 339 | + | |
| 340 | + | |
341 | 341 | | |
342 | 342 | | |
343 | 343 | | |
| |||
372 | 372 | | |
373 | 373 | | |
374 | 374 | | |
375 | | - | |
| 375 | + | |
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
381 | | - | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | 381 | | |
387 | 382 | | |
388 | 383 | | |
| |||
Binary file not shown.
Binary file not shown.
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
0 commit comments