Skip to content

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 7, 2025

VERBOSE is too verbose.

VERBOSE is too verbose.
Copilot AI review requested due to automatic review settings December 7, 2025 21:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the verbosity level of the ddsim command in the warmup_run rule from VERBOSE to DEBUG to reduce excessive logging output during warmup runs that ensure calibrations and fieldmaps are available.

  • Changed the verbosity flag from -v VERBOSE to -v DEBUG in the warmup_run rule

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@veprbl veprbl enabled auto-merge (rebase) December 8, 2025 13:25
veprbl added a commit to eic/epic that referenced this pull request Dec 8, 2025
VERBOSE is supposed to be more verbose than DEBUG.
We need this for eic/detector_benchmarks#246 to work
@veprbl
Copy link
Member Author

veprbl commented Dec 8, 2025

I think I figured what was the issue. It might that running warmup per geometry configuration causes same conflicts that warmup was intended to resolve originally.

This of course does not resolve the core issue - epic geometries can't reliably startup when in the same directory.

@veprbl veprbl changed the title warmup_run: raise verbosity to DEBUG Snakefile: unify warmup runs for different geometries into one Dec 8, 2025
@veprbl veprbl disabled auto-merge December 8, 2025 13:51
@veprbl veprbl enabled auto-merge (squash) December 8, 2025 13:51
@wdconinc
Copy link
Contributor

wdconinc commented Dec 8, 2025

This of course does not resolve the core issue - epic geometries can't reliably startup when in the same directory.

Should we make file loader smarter with flock?

@veprbl
Copy link
Member Author

veprbl commented Dec 8, 2025

This of course does not resolve the core issue - epic geometries can't reliably startup when in the same directory.

Should we make file loader smarter with flock?

That could work. Or just figure out where it exits and make it not exit. Ultimately, the solution with predefined symlinks in local directory will never be safe for local execution (e.g. different versions of epic overwriting symlinks to their calibration paths).

@wdconinc
Copy link
Contributor

wdconinc commented Dec 8, 2025

We can mktemp for a directory with symlinks. Then rm at end. Somehow...

@veprbl
Copy link
Member Author

veprbl commented Dec 8, 2025

We can mktemp for a directory with symlinks. Then rm at end. Somehow...

If there is a way to pass a string with a path to EICrecon. We'd need to also implement a cache to avoid curling all the time and in that cache we may have symlinks to the other cache (from package) that may conflict.

veprbl added a commit to eic/epic that referenced this pull request Dec 8, 2025
VERBOSE is supposed to be more verbose than DEBUG. We need this for
eic/detector_benchmarks#246 to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants