-
Notifications
You must be signed in to change notification settings - Fork 3
Snakefile: unify warmup runs for different geometries into one #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
VERBOSE is too verbose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reduces the verbosity level of the ddsim command in the warmup_run rule from VERBOSE to DEBUG to reduce excessive logging output during warmup runs that ensure calibrations and fieldmaps are available.
- Changed the verbosity flag from
-v VERBOSEto-v DEBUGin the warmup_run rule
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VERBOSE is supposed to be more verbose than DEBUG. We need this for eic/detector_benchmarks#246 to work
|
I think I figured what was the issue. It might that running warmup per geometry configuration causes same conflicts that warmup was intended to resolve originally. This of course does not resolve the core issue - epic geometries can't reliably startup when in the same directory. |
Should we make file loader smarter with flock? |
That could work. Or just figure out where it exits and make it not exit. Ultimately, the solution with predefined symlinks in local directory will never be safe for local execution (e.g. different versions of epic overwriting symlinks to their calibration paths). |
|
We can mktemp for a directory with symlinks. Then rm at end. Somehow... |
If there is a way to pass a string with a path to EICrecon. We'd need to also implement a cache to avoid curling all the time and in that cache we may have symlinks to the other cache (from package) that may conflict. |
VERBOSE is supposed to be more verbose than DEBUG. We need this for eic/detector_benchmarks#246 to work
VERBOSE is too verbose.