Add ROOT import to filterHEPMC3.py #247
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit import ROOT statement at the beginning of filterHEPMC3.py to fix compatibility issues with ROOT 6.38.00. The HepMC3 rootIO module requires ROOT to be imported before use, which was not previously necessary in older ROOT versions but is now required.
Key Changes
- Added
import ROOTbefore importing pyHepMC3 modules to ensure proper initialization of ROOT-based I/O functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
LGTM, but we need to check if it works
Checked that this fix works inside the ROOT 6.38 container. |
And it works in CI here... https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/6923712 |
Briefly, what does this PR introduce?
This adds an explicit
import ROOTbefore the use of the HepMC3 (incl. rootIO) functionality. This appears to be required for ROOT 6.38.00 (https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/6911468#L1101).I'm not entirely happy by my lack of understanding of why this is necessary...
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.