Try to collect configurations from the script which makes them

Author: simonge

.github/workflows/linux-eic-shell.yml

@@ -33,14 +33,18 @@ jobs:
     - uses: actions/checkout@v4
     - id: list-detector-configs
       run: |
-        CONFIGS_CSV=$(
-          ls -1 configurations | sed 's/^/epic_/g' | xargs | sed 's/\.yml//g;s/ /,/g'
-        )
-        CONFIGS_JSON=$((
-          echo '['
-          ls -1 configurations | sed 's/^/epic_/g' | xargs | sed 's/\.yml//g;s/ /, /g' | xargs -n 1 echo | sed -r 's/^([^,]*)(,?)$/"\1"\2/'
-          echo ']'
-        ) | jq -c .)
+        # Collect all config names from all YAMLs, one per line
+        CONFIGS="$(
+          for config in configurations/*.yml; do
+            ./bin/make_detector_configuration -d templates -t epic.xml.jinja2 -c "$config" -o "epic_$(basename "$config" .yml).xml" -p 
+          done | sort -u
+        )"
+        
+        # CSV
+        CONFIGS_CSV="$(echo "$CONFIGS" | paste -sd, -)"
+        # JSON
+        CONFIGS_JSON="$(echo "$CONFIGS" | jq -R -s -c 'split("\n")[:-1]')"
+
         echo "configs_csv=${CONFIGS_CSV}" | tee -a $GITHUB_OUTPUT
         echo "configs_json=${CONFIGS_JSON}" | tee -a $GITHUB_OUTPUT
 

bin/make_detector_configuration

@@ -12,8 +12,11 @@ parser.add_argument('-d', '--dir', type=str, default='templates', help='Template
 parser.add_argument('-t', '--template', type=str, help='Template to render.')
 parser.add_argument('-o', '--output', type=str, help='Output file to write.')
 parser.add_argument('-c', '--config', type=str, help='Config file to load.')
+parser.add_argument('-p', '--print', action='store_true', help='Print the list of configurations to be created without creating them.')
 args = parser.parse_args()
 
+outputs = [args.output]
+
 # template
 env = jinja2.Environment(
     loader = jinja2.FileSystemLoader(args.dir),
@@ -27,8 +30,9 @@ if args.config is not None:
         config = yaml.safe_load(f)
 
 # render the template
-with open(args.output, 'w') as output:
-    output.write(template.render(**config))
+if not args.print:
+    with open(args.output, 'w') as output:
+        output.write(template.render(**config))
 
 # If the config contains far_forward or far_backward create new xml files with ebeam and pbeam set
 if 'features' in config and ('far_forward' in config['features'] or 'far_backward' in config['features']):
@@ -52,11 +56,19 @@ if 'features' in config and ('far_forward' in config['features'] or 'far_backwar
     ]
 
     for values in ebeam_pbeam_values:
+        # Create a new output filename based on the ebeam and pbeam values
+        new_output = args.output.replace('.xml', f"_{values['ebeam']}x{values['pbeam']}.xml")
+        outputs.append(new_output)
+
         # Create a new config dictionary with the current ebeam and pbeam values
         new_config = config.copy()
         new_config.update(values)
+        
+        if not args.print:
+            with open(new_output, 'w') as output:
+                output.write(template.render(**new_config))
 
-        # Render the template with the new config
-        new_output = args.output.replace('.xml', f"_{values['ebeam']}x{values['pbeam']}.xml")
-        with open(new_output, 'w') as output:
-            output.write(template.render(**new_config))
+if args.print:
+    for output in outputs:
+        # Print the output configuration name without the xml extension
+        print(os.path.basename(output).replace('.xml', ''))