-
Notifications
You must be signed in to change notification settings - Fork 54
Setup new far backwards geometry #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simonge
wants to merge
26
commits into
main
Choose a base branch
from
Setup-new-far-backwards-geoemtry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+8,183
−515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…:eic/epic into Add-dipole-steering-magnets-based-on-CAD
…w-far-backwards-geoemtry
for more information, see https://pre-commit.ci
Contributor
Author
for more information, see https://pre-commit.ci
…c into Setup-new-far-backwards-geoemtry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Briefly, what does this PR introduce?
Makes the changes required to match the current EIC accelerator beamline setup in the Far Backward region. The vacuum pipe spanning the tagger drift volume has needed some significant revisions, simplifying the implementation but removing some functionality to allow the "antechamber" design.
Incorporates the volumes reviewed in #978, placed correctly.
Introduces a new script which automatically updates the xml description of the magnets, strengths and positions based on a provided twiss and survey file. (The current files have been added to the calibrations but could be removed as don't do anything other than act as an input to the script.)
Some extra tinkering of positions may be required. In particular the luminosity pipe along the z-axis doesn't extend into the B2AeR magnet. There is a small vacuum/air boundary between the tagger exit windows and the beampipe cylinder. These could be fixed in this PR or a future PR as they won't have the most significant impacts.
The Luminosity components will need their positions updated to match the new layout.
Not the cleanest PR.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Hopefully nothing.
Does this PR change default behavior?
There is likely to be significant changes to the acceptance and reconstruction of the taggers.