feat: Acts Gen3 geometry test #1011
Open
+52
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
commented
Dec 1, 2025
There was a problem hiding this comment.
Pull request overview
This PR introduces support for testing Acts Gen3 geometry alongside the existing Gen1 geometry implementation. The changes enable parallel testing of both geometry generations during the Acts geometry hackathon, allowing for validation and comparison of different geometry approaches.
Key changes:
- Created a new Gen3 geometry test file using Acts' experimental detector builder APIs
- Renamed the original test to
test_ACTS_gen1.cxxwith improved version compatibility handling - Updated the CI workflow to run both Gen1 and Gen3 geometry tests
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/test_ACTS_gen3.cxx | New test file implementing Gen3 geometry using Acts' CylindricalContainerBuilder and DD4hepBlueprintFactory |
| scripts/test_ACTS_gen1.cxx | Renamed from test_ACTS.cxx with enhanced version compatibility for Acts v44+ namespace changes |
| .github/workflows/check-tracking-geometry.yml | Updated to execute both gen1 and gen3 geometry tests in sequence |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Added fstream include for file handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR creates a version of
test_ACTS.cxxfor Gen3 geometry, in order to test changes that will be made in the context of the Acts geometry hackathon this week.