Skip to content

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 8, 2025

VERBOSE is supposed to be more verbose than DEBUG. We need this for eic/detector_benchmarks#246 to work

VERBOSE is supposed to be more verbose than DEBUG.
We need this for eic/detector_benchmarks#246 to work
Copilot AI review requested due to automatic review settings December 8, 2025 13:30
@github-actions github-actions bot added the topic: PID Particle identification label Dec 8, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the logging level for detailed sensor parameter output from DEBUG to VERBOSE in the DRICH geometry code. This aligns with the convention that VERBOSE should provide more detailed output than DEBUG, which is needed for integration with the detector benchmarks repository.

Key Changes:

  • Updated two printout statements from DEBUG to VERBOSE level for sensor parameter listing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@veprbl veprbl merged commit 882a78a into main Dec 8, 2025
108 of 109 checks passed
@veprbl veprbl deleted the pr/drich_verbosity_adjust branch December 8, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: PID Particle identification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants