Multi sensitive volume mpgd #1014
Open
+845
−326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstructors.
- "5SensVolumes" are designed for a 2D-strip readout, via "MPGDTrackerDigi".
- Modified constructors provide for both standard and "5SensVolumes".
- OuterBarrel constructor:
+ Simplified: providing now for only one <module> and one <layer> tag.
+ Sensisitive DetElement: in line with other constructors ("volSurfaceList",...).
…dicated configuration. - Simplication: Standard XML (almost-)free of any reference to strips. - Dedicated "craterlake_tracking_only_2DStrip" implementing "2DStrip" XMLs.
…PIXEL". - 2 flavours of Barrel MPGDs implemented in 2 distinct XMLs: "_pixel"/"_2DStrip". - "-DMPGD_INSTALL_PIXEL" allows to install "_pixel" instead of default "_2DStrip".
…xisting files in "install" directory. - "_pixel" by default: so that the PR checks run successfully even when the new version of "MPGDTrackerDigi" (see "eic/EICrecon#2177") is not in place. - Pre-existing files explicitly erased: since the cmake command "install" does not overwrite existing files.
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
New versions of the XMLs of Barrel MPGDs and updated detector builders to process those.
MPGD_INSTALL_PIXEL) allows to select one or the other flavor.MPGDTrackerDigi.Yet the intent is to eventually have the "_2DStrip" as the default.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Eventually, yes.