nHCal update to 24 mm scintillator #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 layers with 4 cm steel and 0.4 cm scintillator Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Signed-off-by: lkosarz <[email protected]>
…nto negative-HCal-dev
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/hcal_backward.xml Signed-off-by: lkosarz <[email protected]>
Removed empty environments Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Restored rmin and rmax to the decector parameter table Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
…HCal-dev # Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: Kosarzewski <[email protected]>
Changed air gap to 0.5mm = 2*LFHCAL Signed-off-by: Kosarzewski <[email protected]>
Signed-off-by: Kosarzewski <[email protected]>
for more information, see https://pre-commit.ci
Updated description Signed-off-by: lkosarz <[email protected]>
…to nHCal-dev-update # Conflicts: # compact/hcal/backward_LFHCAL_geo.xml
for more information, see https://pre-commit.ci
TODO: invert numbering along z (not necessary for now) Signed-off-by: lkosarz <[email protected]>
…to nHCal-dev-update
Signed-off-by: lkosarz <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: lkosarz <[email protected]>
…to nHCal-dev-update
Signed-off-by: lkosarz <[email protected]>
Made 5x thicker version for sampling fraction study Signed-off-by: lkosarz <[email protected]>
Undetected by overlap check! Signed-off-by: lkosarz <[email protected]>
github-actions
bot
added
topic: backward
Signed-off-by: lkosarz <[email protected]>
veprbl
reviewed
Nov 7, 2025
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
There are more changes than advertised. I'd like to confirm what are we reviewing?
Fixed HcalEndcapN_zmin needed adjustment after changing HcalEndcapN_length 45 cm -> 65 cm Signed-off-by: lkosarz <[email protected]>
…sion_for_sampF for sampling fraction calculation Signed-off-by: lkosarz <[email protected]>
veprbl
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of nHCal geometry to 10x layers of 4 cm steel and 24 mm scintillator
Fixed potential overlap between nHCal and flux return - missed by overlap check, but may affect sampling fraction calculation