-
Notifications
You must be signed in to change notification settings - Fork 54
Add missing detector type flags #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Have you tested querying these values? I don't think this works without explicit calls to |
Oof! I haven't tried it out yet, but I'll report back when I do! If need be, I'll do a pass to add explicit calls where needed... |
Confirmed: you do indeed need an explicit call in each constructor. I just pushed a round of commits to add these calls to all sensitive detectors. I also now have a working example of how to extract the type flags during reconstruction/analysis. I'll do a pass with it to make sure I've haven't missed/messed up anything, and then post here and add the example to either snippets or benchmarks... |
Can you consider if it makes sense to upstream an addition to dd4hep? Symmetric colliders have forward in both directions, so this is EIC-inspired but in some sense of broader relevance too (for all those other asymmetric colliders in development.......). |
Yeah! I definitely think it makes sense upstream it to dd4hep! I suppose the FCC-eh proposal (or LHeC) might some other big use cases 🤷 (Though I also read a fun paper about running a muon collider with asymmetric beam energies a little bit ago...) |




Briefly, what does this PR introduce?
This PR adds DD4hep
DetTypeflags to all sensitive detectors and to beampipes. An example of how to extract these flags from calorimeter and tracker hits (where the latter includes PID output) is provided in snippets here.Note that since only
FORWARDis defined as a flag, I opted to label the FF/FB elements asENDCAP. Then, following what was done in the central tracker, only detectors and beampipes are labeled; support and other structures are not.What kind of change does this PR introduce?
DetType_{ELECTROMAGNETIC, HADRONIC}flags #993 )Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.