feat: add automation rule NONE to booking proto

einride · Dec 21, 2022 · 4fa0f9b · 4fa0f9b
1 parent 00da04d
commit 4fa0f9b
Show file tree

Hide file tree

Showing 5 changed files with 95 additions and 81 deletions.
diff --git a/cmd/saga/gen/einride/saga/extend/book/v1beta1/booking.pb.go b/cmd/saga/gen/einride/saga/extend/book/v1beta1/booking.pb.go
diff --git a/cmd/saga/gen/einride/saga/extend/book/v1beta1/booking_service_cli.pb.go b/cmd/saga/gen/einride/saga/extend/book/v1beta1/booking_service_cli.pb.go
diff --git a/openapiv2/book.swagger.yaml b/openapiv2/book.swagger.yaml
@@ -315,12 +315,14 @@ definitions:
   BookingAutomationRule:
     type: string
     enum:
+      - NONE
       - CREATE_SHIPMENTS
       - CREATE_AND_RELEASE_SHIPMENTS
     description: |-
       The rule that is applied when a confirmed booking is accepted.
 
        - AUTOMATION_RULE_UNSPECIFIED: Unspecified auto rule.
+       - NONE: No automation rule
        - CREATE_SHIPMENTS: When the confirmed booking is accepted, shipments will be created automatically from its stops and units.
        - CREATE_AND_RELEASE_SHIPMENTS: When the confirmed booking is accepted, shipments will be created automatically from its stops and units
       and then released.
@@ -619,7 +621,7 @@ definitions:
     properties:
       automationRule:
         $ref: '#/definitions/BookingAutomationRule'
-        description: The rule that is applied when a confirmed booking is accepted. Defaults to no auto rule.
+        description: The rule that is applied when a confirmed booking is accepted. Defaults to NONE.
       createTime:
         type: string
         format: date-time

diff --git a/proto/einride/saga/extend/book/v1beta1/booking.proto b/proto/einride/saga/extend/book/v1beta1/booking.proto
@@ -46,7 +46,7 @@ message Booking {
   ServiceType service_type = 8 [(google.api.field_behavior) = REQUIRED];
   // External reference ID is a unique identifier that can be set by the client.
   string external_reference_id = 9;
-  // The rule that is applied when a confirmed booking is accepted. Defaults to no auto rule.
+  // The rule that is applied when a confirmed booking is accepted. Defaults to NONE.
   AutomationRule automation_rule = 10;
 
   // The units included in this booking.
@@ -100,11 +100,13 @@ message Booking {
   enum AutomationRule {
     // Unspecified auto rule.
     AUTOMATION_RULE_UNSPECIFIED = 0;
+    // No automation rule
+    NONE = 1;
     // When the confirmed booking is accepted, shipments will be created automatically from its stops and units.
-    CREATE_SHIPMENTS = 1;
+    CREATE_SHIPMENTS = 2;
     // When the confirmed booking is accepted, shipments will be created automatically from its stops and units
     // and then released.
-    CREATE_AND_RELEASE_SHIPMENTS = 2;
+    CREATE_AND_RELEASE_SHIPMENTS = 3;
   }
 
   // A stop is an address where an event is going to happen. The event could be