Skip to content

Improvement suggestion for filter.py #10

Description

@rottenstea

The filter function code is neat! My suggestion is that you could improve the is_observable function by validating whether the value you read in from the XML file for the declination is indeed a real coordinate within the expected value range, to avoid troubles if your data have NaN values or numeric placeholders for NaNs (-9999 etc).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions