Skip to content

Commit 461ec1d

Browse files
eitoballCopilot
andcommitted
Document PR 25 conflict resolution
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 70db161 commit 461ec1d

1 file changed

Lines changed: 21 additions & 0 deletions

File tree

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# PR #25 HTTP Query Support Design
2+
3+
## Scope
4+
5+
Resolve PR #25 against the current `master` branch. Preserve query strings
6+
when `Net::Ping::HTTP` constructs the path for its `Net::HTTP` request.
7+
8+
## Implementation
9+
10+
Replace the path-only value passed to `Net::HTTP::Get` or `Net::HTTP::Head`
11+
with `URI#request_uri`. This retains the existing `/` fallback for an empty
12+
path and includes the query component for non-empty paths.
13+
14+
Add a WebMock regression test using a URL whose query parameter distinguishes
15+
the registered request from its path-only variant. The query-bearing request
16+
must succeed.
17+
18+
## Validation
19+
20+
Run `bundle exec rake test:http`. The test confirms the request path includes
21+
the query string while preserving existing HTTP ping behavior.

0 commit comments

Comments
 (0)