ci: apply review fixes, check docs, and use drafts

Author: ekaf

.github/workflows/release.yml

@@ -3,53 +3,76 @@ name: Release
 on:
   push:
     tags:
-      - 'v*.*.*'
-
-permissions:
-  contents: write
+      - '*'
 
 jobs:
-  test:
+  gate-on-ci:
+    name: Gate release on CI success for this tag commit
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ['3.10', '3.11', '3.12', '3.13', '3.14', '3.14t']
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v6
-      - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v6
+      - name: Checkout repository
+        uses: actions/checkout@v4
         with:
-          python-version: ${{ matrix.python-version }}
-      - name: Install dependencies
+          fetch-depth: 0
+
+      - name: Check that release tag points to a develop commit
         run: |
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt
-      - name: Run tests
-        run: pytest
+          git merge-base --is-ancestor "$GITHUB_SHA" origin/develop
+
+      - name: Verify version string in documentation
+        run: |
+          VERSION=${GITHUB_REF_NAME#v}
+          echo "Checking files for version: $VERSION"
+
+          for file in nltk/VERSION ChangeLog web/news.rst web/conf.py; do
+            if grep -Fq "$VERSION" "$file"; then
+              echo "✅ Found $VERSION in $file"
+            else
+              echo "❌ ERROR: Version $VERSION not found in $file!"
+              exit 1
+            fi
+          done
+
+      - name: Wait for ci.yml to complete and verify success
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          run=$(gh api repos/${{ github.repository }}/actions/commits/$GITHUB_SHA/runs --jq '.workflow_runs[] | select(.name == "CI") | head -n 1')
+          conclusion=$(jq -r '.conclusion // empty' <<< "$run")
 
-  build-and-release:
+          if [ "$conclusion" != "success" ]; then
+            run_id=$(jq -r '.id // empty' <<<"$run")
+            run_number=$(jq -r '.run_number // empty' <<<"$run")
+            run_url="https://github.com/${{ github.repository }}/actions/runs/${run_id}"
+            echo "CI failed with conclusion: ${conclusion:-unknown} (run #${run_number:-unknown}). See workflow run: ${run_url}"
+            exit 1
+          fi
+
+  build-and-github-release:
+    needs: gate-on-ci
+    name: Build and create GitHub draft release
     runs-on: ubuntu-latest
-    needs: test
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v6
-      - name: Set up Python 3.14
-        uses: actions/setup-python@v6
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
         with:
-          python-version: 3.14
-      - name: Install dependencies
+          python-version: '3.10'
+
+      - name: Install build dependencies
         run: |
           python -m pip install --upgrade pip
           pip install -r requirements.txt
           pip install build
-      - name: Build distributions
+
+      - name: Build package
         run: python -m build
-      - name: Upload Release Assets
+
+      - name: Create GitHub Release
         uses: softprops/action-gh-release@v2
         with:
-          files: |
-            dist/*.whl
-            dist/*.tar.gz
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          files: dist/*
+          draft: true
+          generate_release_notes: true