[Task] Increase unit test coverage of create iamserviceccount

[TiberiuGC]

Should unit test the logic under doCreateIAMServiceAccount func. I.e the providerExists check, the excludeExistingFilter and the warning messages that come with --role-only and --override-existing-serviceaccounts flags.

[TiberiuGC]

For the warning messages bit (introduced with #5856), I have written a helper function which anyone who picks up the ticket can copy as is, if they find it appropriate.

func checkExpectedLogs(output *bytes.Buffer, args ...string) {
	messages := []string{
		"serviceaccounts in Kubernetes will not be created or modified, since the option --role-only is used",
		"when option --role-only is used passing --override-existing-serviceaccounts has no effect",
		"metadata of serviceaccounts that exist in Kubernetes will be updated, as --override-existing-serviceaccounts was set",
		"serviceaccounts that exist in Kubernetes will be excluded, use --override-existing-serviceaccounts to override",
	}

	expectedMessages := map[string]bool{
		messages[0]: false,
		messages[1]: false,
		messages[2]: false,
		messages[3]: false,
	}

	var roleOnly, overrideExistingServiceAccounts bool
	for _, arg := range args {
		if arg == "--role-only" {
			roleOnly = true
		}
		if arg == "--override-existing-serviceaccounts" {
			overrideExistingServiceAccounts = true
		}
	}

	if roleOnly {
		expectedMessages[messages[0]] = true
		if overrideExistingServiceAccounts {
			expectedMessages[messages[1]] = true
		}
	} else if overrideExistingServiceAccounts {
		expectedMessages[messages[2]] = true
	} else {
		expectedMessages[messages[3]] = true
	}

	for message, expected := range expectedMessages {
		if expected {
			Expect(output.String()).To(ContainSubstring(message))
			continue
		}
		Expect(output.String()).NotTo(ContainSubstring(message))
	}
}

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.