Skip to content

Commit d6f692e

Browse files
Add TODO.
1 parent 909f287 commit d6f692e

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

scripts/nerfcapture2dataset.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ def dataset_capture_loop(json_data, save_path: Path, overwrite: bool, n_frames:
127127
os.path.basename(args.config), args.config
128128
).load_module()
129129

130+
# TODO(Santoi): Improve config sharing between scripts.
130131
config = experiment.config
131132
config['workdir'] = args.base_dir + "/" + args.scene
132133
config['data']['num_frames'] = config['num_frames'] = args.frames / 3 # SplaTAM usually stars to go nuts after 1/3 of the dataset frames.

scripts/splatam.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,6 +1004,7 @@ def rgbd_slam(config: dict):
10041004
os.path.basename(args.experiment), args.experiment
10051005
).load_module()
10061006

1007+
# TODO(Santoi): Improve config sharing between scripts.
10071008
experiment.config['workdir'] = args.base_dir + "/" + args.scene
10081009
experiment.config['data']['num_frames'] = experiment.config['num_frames'] = int(args.frames / 3) # SplaTAM usually stars to go nuts after 1/3 of the dataset frames.
10091010
experiment.config['data']['basedir'] = experiment.config['basedir'] = args.base_dir

viz_scripts/final_recon.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,11 +289,12 @@ def visualize(scene_path, cfg):
289289
os.path.basename(args.experiment), args.experiment
290290
).load_module()
291291

292-
seed_everything(seed=experiment.config["seed"])
292+
# TODO(Santoi): Improve config sharing between scripts.
293293
experiment.config['workdir'] = args.base_dir + "/" + args.scene
294294
experiment.config['data']['num_frames'] = experiment.config['num_frames'] = int(args.frames / 3) # SplaTAM usually stars to go nuts after 1/3 of the dataset frames.
295295
experiment.config['data']['basedir'] = experiment.config['basedir'] = args.base_dir
296296
experiment.config['data']['sequence'] = experiment.config['scene_name'] = args.scene
297+
seed_everything(seed=experiment.config["seed"])
297298

298299
if "scene_path" not in experiment.config:
299300
results_dir = os.path.join(

0 commit comments

Comments
 (0)