Prefer nerd font to correctly render icons

[pnodet]

The google font version of Fira Code doesn't handle icons existing in the nerd font version.

One thing to consider is that it's not a variable font, maybe worth taking into consideration.

[ekzhang]

Thanks for the suggestion! It's interesting to hear how other people use terminal fonts.

I'm actually using the official Fira Code package, not the Google Fonts version. Perhaps I can add a font switcher to the UI so people can choose their preferred setting!

[pnodet]

Sure, would love this!
From the reactions to my issue above I think many would like it as well.

One "technical" challenge is that I'm not sure the nerd fonts are hosted by unpkg like the Fira Code, I don't know how the font switcher should handle this, maybe downloading and hosting some fonts in the repo would be a solution, and allowing users to choose between provided fonts.

[ekzhang]

We're not hosting them on unpkg; the fonts are served by our server.

[silopolis]

Yes please!
My lsd is on a bad trip without it ;)

Of course, a font selector would be freaking cool...

Thanks for this fantastic gem 🙏
Take care
J

[ThatOneCalculator]

Any update on this?

[Jacques-z]

I don't know if this is a good solution:

Store fonts info in a json. For each font we run npm i ${font}. Also export an obj { fontList, changeFont }, where changeFont accepts font args, imports font, and applies font-family
updates.

Here's a concern: Deleting entries in the fonts json should trigger a npm uninstall, so should we record them in a lock file or so.

Does this seem to be a good idea? If so, I can try to work on it.

[ekzhang]

Any update on this?

Looks like I'd need to vendor in the FiraCodeNerdFontMono-Regular.ttf and FiraCodeNerdFontPropo-Medium.ttf files. It's not that simple though since it's complicated by needing to use FontFaceObserver class to detect font loading for both 400 and 500 weights and make it depend on the users' settings.