Skip to content

Commit 45d36cc

Browse files
Liraz ShalomLiraz Shalom
authored andcommitted
Bug fixes and improvements following initial review
I'm glad you like the design! :) I tried to address all the issues you mentioned: **UI Changes:** - Switched the **collapsing toolbar layout** for a standard TopAppBar/back to the action bar - Improved **title display** when clicking an alert - Fixed the **map showing cropped** - Fixed the **share button stuttering** when switching to map tab for a moment **Bug Fixes:** - Fixed the **map only loading on automatic map reload** and taking 10 seconds to load - Got **share button** back - Fixed the **restore button not showing** on the alerts list after clearing all alerts - Fixed the **"Select your city" popup** to redirect to the actual city selection dialog **Improvements:** - Added back a **loading indicator** on automatic map refreshes - Added an **animation for clearing and restoring** the recent alerts list :) - Implemented **asynchronous loading** for the map when going to the map tab (preventing delay when switching to it) - Added **predictive back animation** when switching between settings screens - Made the action bar title **immediately change back** to recent alerts when going back from an alert rather than waiting for animation to finish to make the app feel more responsive **Other:** - Updated to **TargetSdkVersion 35** I couldn't seem to reproduce the 2 clear recent alerts buttons appearing or the back button not working when viewing an individual alert - could you please check if it's working as expected for you now? :)
1 parent 0978a60 commit 45d36cc

146 files changed

Lines changed: 7480 additions & 3244 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

app/build.gradle

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ android {
1010
applicationId "com.red.alert"
1111
minSdkVersion 21
1212
targetSdkVersion 35
13-
versionCode 10960
14-
versionName "1.0.96"
13+
versionCode 10970
14+
versionName "1.0.97"
1515
}
1616
buildTypes {
1717
release {
@@ -29,6 +29,23 @@ dependencies {
2929

3030
// AppCompat v7 Dependency
3131
implementation 'androidx.appcompat:appcompat:1.7.0'
32+
implementation 'androidx.fragment:fragment:1.8.1'
33+
implementation 'androidx.activity:activity:1.9.0'
34+
35+
// Material Design 3
36+
implementation 'com.google.android.material:material:1.12.0'
37+
38+
// AndroidX Preference Library
39+
implementation 'androidx.preference:preference:1.2.1'
40+
41+
// RecyclerView
42+
implementation 'androidx.recyclerview:recyclerview:1.3.2'
43+
44+
// CardView
45+
implementation 'androidx.cardview:cardview:1.0.0'
46+
47+
// Swipe to Refresh
48+
implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
3249

3350
// Firebase Cloud Messaging
3451
implementation "com.google.firebase:firebase-messaging:24.1.1"

app/src/main/AndroidManifest.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<uses-permission android:name="android.permission.INTERNET"/>
99
<uses-permission android:name="android.permission.WAKE_LOCK"/>
1010
<uses-permission android:name="android.permission.ACCESS_NOTIFICATION_POLICY"/>
11+
<uses-permission android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS"/>
1112
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
1213
<uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
1314
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>
@@ -38,6 +39,7 @@
3839
android:name=".App"
3940
android:supportsRtl="true"
4041
android:label="@string/appName"
42+
android:enableOnBackInvokedCallback="true"
4143
android:icon="@drawable/ic_launcher">
4244

4345
<!-- Google Maps v2 Public API Key -->

0 commit comments

Comments
 (0)