Refine timestamp tests and update user transformer (#264)

Author: elamperti

src/store/reducers/alertReducer.test.ts

@@ -0,0 +1,38 @@
+import alertReducer from './alertReducer';
+
+import { ALERT_CLEAR_ALL, ALERT_CREATE, ALERT_DISMISS } from 'Constants';
+
+import type { Alert } from 'components/AlertZone/types';
+
+describe('alertReducer', () => {
+  it('creates alerts with generated ids', () => {
+    const state = alertReducer([], {
+      type: ALERT_CREATE,
+      payload: { message: 'Hello world' },
+    });
+    expect(state).toHaveLength(1);
+    expect(state[0]).toMatchObject({ message: 'Hello world', persistent: false });
+    expect(state[0].id).toBeDefined();
+  });
+
+  it('dismisses alerts matching payload properties', () => {
+    const initial: Alert[] = [
+      { id: '1', message: 'a', title: '', type: 'info', persistent: false },
+      { id: '2', message: 'b', title: '', type: 'info', persistent: false },
+    ];
+    const state = alertReducer(initial, {
+      type: ALERT_DISMISS,
+      payload: { id: '1' },
+    });
+    expect(state).toEqual([{ id: '2', message: 'b', title: '', type: 'info', persistent: false }]);
+  });
+
+  it('clears non persistent alerts', () => {
+    const initial: Alert[] = [
+      { id: '1', message: 'a', title: '', type: 'info', persistent: false },
+      { id: '2', message: 'b', title: '', type: 'info', persistent: true },
+    ];
+    const state = alertReducer(initial, { type: ALERT_CLEAR_ALL });
+    expect(state).toEqual([{ id: '2', message: 'b', title: '', type: 'info', persistent: true }]);
+  });
+});

src/utils/clients/api/transformers/settings.transformer.test.ts

@@ -0,0 +1,37 @@
+import { settingsTransformer } from './settings.transformer';
+
+describe('settingsTransformer', () => {
+  it('applies defaults when values are missing', () => {
+    expect(settingsTransformer(undefined)).toEqual({
+      lang: 'auto',
+      use12Hours: false,
+      catchPaste: true,
+      showTrackNumbers: false,
+      hasActiveSubscription: false,
+      keepOriginalTimestamp: true,
+      patreonId: '',
+    });
+  });
+
+  it('transforms provided settings correctly', () => {
+    const raw = {
+      lang: 'es',
+      use12Hours: true,
+      catchPaste: false,
+      showTrackNumbers: true,
+      activeSubscription: true,
+      keepOriginalTimestamp: false,
+      patreonId: '12345',
+    };
+
+    expect(settingsTransformer(raw)).toEqual({
+      lang: 'es',
+      use12Hours: true,
+      catchPaste: false,
+      showTrackNumbers: true,
+      hasActiveSubscription: true,
+      keepOriginalTimestamp: false,
+      patreonId: '12345',
+    });
+  });
+});

src/utils/clients/api/transformers/user.transformer.test.ts

@@ -0,0 +1,40 @@
+import { userTransformer } from './user.transformer';
+
+describe('userTransformer', () => {
+  it('transforms a full response correctly', () => {
+    const raw = {
+      token: 'abc123',
+      user: {
+        id: '42',
+        name: 'Sufjan',
+        url: 'https://example.com/sufjan',
+        image: [
+          { size: 'small', '#text': 'sm.jpg' },
+          { size: 'medium', '#text': 'md.jpg' },
+        ],
+      },
+      isLoggedIn: true,
+    };
+
+    expect(userTransformer(raw)).toEqual({
+      token: 'abc123',
+      user: {
+        id: '42',
+        name: 'Sufjan',
+        avatar: { sm: 'sm.jpg', md: 'md.jpg' },
+        url: 'https://example.com/sufjan',
+      },
+      isLoggedIn: true,
+    });
+  });
+
+  it('infers logged in state when missing flag', () => {
+    const raw = {
+      user: {
+        name: 'Kurt Cobain',
+      },
+    };
+
+    expect(userTransformer(raw).isLoggedIn).toBe(true);
+  });
+});

src/utils/datetime.test.ts

@@ -1,12 +1,50 @@
-import { formatDuration } from './datetime';
+import { formatDuration, formatScrobbleTimestamp } from './datetime';
 
 describe('`formatDuration` helper', () => {
   it('is correct', () => {
     expect(formatDuration(45)).toEqual('0:45');
     expect(formatDuration(150)).toEqual('2:30');
-    expect(formatDuration(187)).toEqual('3:07');
-    expect(formatDuration(777)).toEqual('12:57');
     expect(formatDuration(3801)).toEqual('1:03:21');
-    expect(formatDuration(4202)).toEqual('1:10:02');
+  });
+
+  it('handles durations over 13 hours', () => {
+    expect(formatDuration(13 * 3600 + 5)).toEqual('13:00:05');
+  });
+
+  it('handles durations over 25 hours', () => {
+    expect(formatDuration(25 * 3600 + 3)).toEqual('1:00:03');
+  });
+});
+
+describe('`formatScrobbleTimestamp` helper', () => {
+  beforeEach(() => {
+    vi.useFakeTimers();
+    vi.setSystemTime(new Date('2025-06-15T12:00:00Z'));
+  });
+
+  afterEach(() => {
+    vi.useRealTimers();
+  });
+
+  describe('24-hour format', () => {
+    it('formats today, same year and previous year timestamps', () => {
+      const today = new Date('2025-06-15T09:30:00');
+      const sameYear = new Date('2025-02-01T17:05:00');
+      const prevYear = new Date('2024-12-31T23:59:00');
+
+      expect(formatScrobbleTimestamp(today, false)).toBe('09:30');
+      expect(formatScrobbleTimestamp(sameYear, false)).toBe('1/02 17:05');
+      expect(formatScrobbleTimestamp(prevYear, false)).toBe('31/12/2024 23:59');
+    });
+  });
+
+  describe('12-hour format', () => {
+    it('formats same year and previous year timestamps', () => {
+      const sameYear = new Date('2025-02-01T17:05:00');
+      const prevYear = new Date('2024-12-31T17:05:00');
+
+      expect(formatScrobbleTimestamp(sameYear, true)).toBe('2/1 05:05 PM');
+      expect(formatScrobbleTimestamp(prevYear, true)).toBe('12/31/2024 05:05 PM');
+    });
   });
 });