only send notification once, when bulk scheduling

Author: tgloeggl

controllers/course.php

@@ -434,6 +434,8 @@ public function schedule_action($resource_id, $termin_id)
 
         $this->schedule($resource_id, $termin_id, $this->course_id);
 
+        $this->sendRecordingNotifications($this->course_id);
+
         $this->redirect('course/scheduler?semester_filter=' . Request::option('semester_filter'));
     }
 
@@ -630,6 +632,10 @@ public function bulkschedule_action()
             }
         }
 
+        if ($action == 'create') {
+            $this->sendRecordingNotifications($this->course_id);
+        }
+
         $this->redirect('course/scheduler?semester_filter=' . Request::option('semester_filter'));
     }
 
@@ -642,26 +648,6 @@ public function schedule($resource_id, $termin_id, $course_id)
             $scheduler_client = SchedulerClient::getInstance(OCConfig::getConfigIdForCourse($course_id));
 
             if ($scheduler_client->scheduleEventForSeminar($course_id, $resource_id, $termin_id)) {
-                $course = Course::find($course_id);
-                $members = $course->members;
-                $users = [];
-
-                foreach ($members as $member) {
-                    $users[] = $member->user_id;
-                }
-
-                $notification = sprintf(
-                    $this->_('Die Veranstaltung "%s" wird für Sie mit Bild und Ton automatisiert aufgezeichnet.'),
-                    htmlReady($course->name)
-                );
-                PersonalNotifications::add(
-                    $users,
-                    $this->url_for('course/index', ['cid' => $course_id]),
-                    $notification,
-                    $course_id,
-                    Icon::create($this->plugin->getPluginUrl() . '/images/opencast-black.svg')
-                );
-
                 StudipLog::log('OC_SCHEDULE_EVENT', $termin_id, $course_id);
 
                 PageLayout::postSuccess(
@@ -710,6 +696,29 @@ public function updateschedule($resource_id, $termin_id, $course_id)
         }
     }
 
+    private function sendRecordingNotifications($course_id)
+    {
+        $course = Course::find($course_id);
+        $members = $course->members;
+        $users = [];
+
+        foreach ($members as $member) {
+            $users[] = $member->user_id;
+        }
+
+        $notification = sprintf(
+            $this->_('Die Veranstaltung "%s" wird für Sie mit Bild und Ton automatisiert aufgezeichnet.'),
+            htmlReady($course->name)
+        );
+        PersonalNotifications::add(
+            $users,
+            $this->url_for('course/index', ['cid' => $course_id]),
+            $notification,
+            $course_id,
+            Icon::create($this->plugin->getPluginUrl() . '/images/opencast-black.svg')
+        );
+    }
+
     public function unschedule($resource_id, $termin_id, $course_id)
     {
         $scheduled = OCModel::checkScheduledRecording($course_id, $resource_id, $termin_id);