Fix and review for the hardcoded permission checks in API Routes and UI #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one with configs and co. fixes elan-ev#1218
the canEdit prop is no longer needed since the canUpload prop and associated permission checks in the Perm class already determine whether a user has edit rights.
Instead of removing the bulk action feature for students with upload permissions, we now first check the video list. If the user has either write or owner permissions for any video, the bulk action option will be displayed.
tgloeggl
approved these changes
Apr 24, 2025
|
This pull request has conflicts ☹ |
|
Rebased and moved to new PR: #1342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1218,
It is at the moment a draft PR as there are some more places left to check.
This PR will be updated and more commits are yet to come.