Skip to content

Retrofit --add-account with the CLI option validator and frontend-message fix #1509

Description

@simtel12

`handle_add_account` (`lib/common/cli/cli_orchestration.rb:77-122`) still parses `--frontend` with the raw, unchecked `ARGV.index('--frontend') + 1` pattern that #1504 replaced elsewhere with `CliOptionValidator.extract_flag_value`. Wire it in the same way.

Separately, `add_account`'s success block (`lib/common/authentication/cli_password.rb`, ~line 178-181) has the same misleading "Frontend not set" message bug that was fixed in `refresh_characters` in #1504 (commit f8991ca) but was explicitly left untouched in `add_account`. Apply the same fix.

Add `handle_add_account` test coverage as part of this ticket.

Note: frontend account-scoping (`determine_predominant_frontend`) does not need retrofitting here - `add_account`'s call site was already updated in #1504 (commit 198f485).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions