Skip to content

Commit 7dfd0ea

Browse files
authored
Fix #2415 lookup for SqlRoleProvider breaks in ASP.NET identity 2 (#2417)
1 parent 2d1a0db commit 7dfd0ea

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

CHANGELOG.asciidoc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ endif::[]
2323
[[release-notes-1.x]]
2424
=== .NET Agent version 1.x
2525
26+
[[release-notes-1.28.2]]
27+
==== 1.28.2 - 2024/08/14
28+
29+
===== Bug fixes
30+
31+
{pull}2415[#2415] Fixed check for SqlRoleProvider under AspNet Identity 2.
32+
2633
[[release-notes-1.28.1]]
2734
==== 1.28.1 - 2024/08/12
2835

src/integrations/Elastic.Apm.AspNetFullFramework/ElasticApmModule.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,9 @@ private void FillSampledTransactionContextUser(HttpContext context, ITransaction
631631
return;
632632

633633
var user = new User { UserName = userIdentity.Name };
634-
var sqlRoleProvider = System.Web.Security.Roles.Providers.Cast<object>().Any(provider => provider.GetType().Name == "SqlRoleProvider");
634+
635+
var sqlRoleProvider =
636+
System.Web.Security.Roles.Enabled && System.Web.Security.Roles.Providers.Cast<object>().Any(provider => provider.GetType().Name == "SqlRoleProvider");
635637
if (!sqlRoleProvider && context.User is ClaimsPrincipal claimsPrincipal)
636638
{
637639
try

0 commit comments

Comments
 (0)