Copy span context for Error.context

[felixbarny]

Currently, only the context is only copied in case an error on a transaction has been recorded.

[felixbarny]

Test that the UI can cope with errors which have a span context.

[felixbarny]

Another problem is that we don't collect tags and other context data like ES or JDBC queries if the span is not sampled.

[felixbarny]

@elastic/apm-server Is that even possible from an API level? The scenario is for example to record an exception for a DB query. Currently, the transaction's context would be copied to the error's context. When it actually seems more appropriate to copy the span context to the error. That way, users can re-run the recorded context.db.statement, for example.

But I think this is not allowed via the API. error.context refers to the transaction context object: , whereas the span.context is a separate thing. However, the context object does not disallow additional attributes, so from a API perspective, this may just work.

But another problem is that the UI would probably not be prepared to display a span context object within an error object 🤔.

[jalvz]

However, the context object does not disallow additional attributes, so from a API perspective, this may just work

It wouldn't be validated, but it should work, yes. I think you are also right about the UI, I recall they need to know the top level keys inside context, but I might be wrong.