Skip to content

Commit 18cc1da

Browse files
authored
chore(dev-deps): bump to [email protected] and refine the min-supported Node.js range for it (#4901)
Tedious 19 really supports '^18.17.0 || >=20.3.0' Refs: #4882
1 parent f770552 commit 18cc1da

File tree

3 files changed

+64
-51
lines changed

3 files changed

+64
-51
lines changed

.tav.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,11 +373,12 @@ tedious:
373373
mode: latest-majors
374374
node: '18.x || >=20'
375375
commands: node test/instrumentation/modules/tedious.test.js
376-
# Tedious v19 advertise a min-supported Node.js version of 18.17.0.
376+
# Tedious v19 advertise a min-supported Node.js version of 18.17.0, but
377+
# AbortSignal.any usage implies >=20.3.0 as well.
377378
- versions:
378379
include: '>=19 <20'
379380
mode: latest-majors
380-
node: '>=18.17'
381+
node: '^18.17.0 || >=20.3.0'
381382
commands: node test/instrumentation/modules/tedious.test.js
382383

383384
cassandra-driver:

package-lock.json

Lines changed: 59 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/instrumentation/modules/tedious.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ if (
3333
// Node.js <16 has been broken.
3434
(semver.gte(tediousVer, '11.0.0') && semver.lt(process.version, '16.0.0')) ||
3535
// tedious@19 drops support for Node.js <v18.17
36-
(semver.gte(tediousVer, '19.0.0') && semver.lt(process.version, '18.17.0'))
36+
(semver.gte(tediousVer, '19.0.0') &&
37+
!semver.satisfies(process.version, '^18.17.0 || >=20.3.0'))
3738
) {
3839
console.log(
3940
`# SKIP tedious@${tediousVer} does not support node ${process.version}`,

0 commit comments

Comments
 (0)