ci: `run-patch-release` tries to run unexisting make target `update-docs`

[endorama]

RELEASE.md specified to run run-patch-release GitHub workflow when a new patch release should be cut from the release branch.

Trying to follow through for the next 7.17 release I run that workflow but it failed with No rule to make target 'update-docs'; see logs:

Run make patch-release
INFO: Create feature branch and update the versions. Target branch main.
create-branch update-7.17.23
  Switched to a new branch 'main'
  branch 'main' set up to track 'origin/main'.
  Switched to a new branch 'update-7.17.23'
go: downloading go1.22.1 (linux/amd64)
>> update-version
make[1]: *** No rule to make target 'update-docs'.  Stop.
make: *** [release.mk:140: patch-release] Error 2
Error: Process completed with exit code 2.

That target has been removed in c25abdd for releases >8.13, so I expect it to be available on 7.17 and I can grep for it locally:

❯ ag update-docs
release.mk
119:	$(MAKE) update-docs VERSION=$(RELEASE_VERSION)
140:	$(MAKE) update-docs VERSION=$(RELEASE_VERSION)
185:.PHONY: update-docs
186:update-docs: VERSION=$${VERSION}
187:update-docs: setup-yq
188:	@echo ">> update-docs"

The CI job did check out branch 7.17, so I'm not sure why this failure.

As a workaround I've been able to run the command locally with:

❯ RELEASE_BRANCH=7.17 RELEASE_VERSION=7.17.22 make patch-release

to create this PR

[v1v]

PR:

• ci: fix type of release #13382

I'm trying to recall how it worked in the past, and likely. it did when I tried locally but in the GitHub actions it didn't work.

Regardless, you can run using main always for minor and patch releases. The version is the important input parameter and will be used to switch to the specific branch (main, 7.17 or 8.14 ...)

[endorama]

@v1v thanks for chiming in! So the issue here is that I run the workflow from branch 7.17 instead of main? I'll document this, as I guessed I needed to use the correct release branch.

[v1v]

The CI job did check out branch 7.17, so I'm not sure why this failure.

The problem is related to the RELEASE_TYPE?= minor therefore it uses main as the default branch and the makefile branches off from main.

Even though it initially used the 7.17 branch, as you pointed in the description with the screenshot.

Therefore the new makefile was the one from main and therefore the target update-docs is not available anymore in main or 8.14 .

So the issue here is that I run the workflow from branch 7.17 instead of main

It should behave similarly. The issue was that patch-release didn't set the variable RELEASE_TYPE=patch, then it won't use the main branch but the 7.17 or 8.14.

For simplicity, you don't need to change the branch when running the run-patch or run-minor but set the new version only.

[endorama]

Thanks for the explanations and the fix! ❤️

[endorama]

Improved docs around how to run the workflows in 97877ca (#13339)

[endorama]

#13380 has been merged and I added some clarification to the RELEASE.md file in 97877ca (#13339). Closing