Windows: service installed has weird name

[inge4pres]

APM Server version (apm-server version):

8.17.0 and main

Description of the problem including expected versus actual behavior:

Env: Windows
The installer configures a service with a bad name {.BeatName | title}.

Steps to reproduce:

1. Go to https://www.elastic.co/downloads/apm
2. follow the instructions to install the service
3. open Super+R -> services.msc

Provide logs (if relevant):

N/A

Possible cause

Might be that a missing Go template variable isn't passed to the service install script?

[axw]

apm-server/packaging/files/windows/install-service.ps1

Line 13 in 71b8b00

-displayName {{.BeatName | title}} `

This was copied from Beats where it was a template, but it's not a template in the apm-server repo. I think we just need to change that to -displayName "Elastic APM Server" or whatever we want it to say.

[inge4pres]

Thanks, as suggested by @kruskall we have incorporated a fix for this in #14905