-
Notifications
You must be signed in to change notification settings - Fork 541
Open
Labels
Description
The current patch release workflow is a bit confusing and generally results in a developer making manual changes versus relying on the automation.
Goals
- Update the release workflow to avoid having to provide
X.Y.Z+1i.e for the8.18.7we should not have to pass8.18.8. This is most likely due toupdate-versionexpecting the next release version here. A possible solution is listed below:- We already calculate X.Y.Z+1 here under the NEXT_RELEASE var: https://github.com/elastic/apm-server/blob/main/release.mk#L47
- Example assuming the release is for 8.18.7 (env var RELEASE_VERISON)
- This var is used to create the new branch update-8.18.8. But we pass in the RELEASE_VERISON to update-version https://github.com/elastic/apm-server/blob/main/release.mk#L47
- So this should be updated to :
$(MAKE) update-version VERSION=$ (NEXT_RELEASE) ?
- The automation creates a misleading branch. Example for the
8.18.7release, the automation will create a branchupdate-8.18.8to change all necessary files to the next version8.18.8. The branch name implies the we are updating8.18.8versus changing files to bump to8.18.8. This should help avoid any confusion on the purpose of the branch, especially for anyone not familiar with the details of the release workflows. - Update release documentation to clarify instructions
simittCopilot