[8.19](backport #48644) [perfmon/windows] - Add the ability to extract object names from counters#48882
Open
mergify[bot] wants to merge 1 commit into8.19from
Open
[8.19](backport #48644) [perfmon/windows] - Add the ability to extract object names from counters#48882mergify[bot] wants to merge 1 commit into8.19from
mergify[bot] wants to merge 1 commit into8.19from
Conversation
…ters (#48644) * initial commit * add tests * changelog * docs * lint * unset * doc * docs * fix unit tests * enhance regex * Update metricbeat/module/windows/perfmon/_meta/docs.md Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> * Update docs/reference/metricbeat/metricbeat-metricset-windows-perfmon.md Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> --------- Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 4a1bba9)
mergify
bot
requested review from
faec and
leehinman
and removed request for
a team
botelastic
bot
added
the
needs_team
Contributor
🤖 GitHub commentsJust comment with:
|
github-actions
bot
added
Team:Docs
botelastic
bot
removed
the
needs_team
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Contributor
|
@copilot Review this PR for me. |
|
@VihasMakwana I've opened a new pull request, #49034, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
When using wildcards for perfmon objects in the windows Integration, the windows.perfmon.object field should show the actual object name, not the wildcard
Previously, when using wildcards for Perfmon objects in the Windows Integration, the windows.perfmon.object field would retain the wildcard instead of reporting the actual object name.
For example, given the following Perfmon objects:
and the following Perfmon collection configuration:
all instances from all databases are discovered and reported. However, the
windows.perfmon.objectfield would show*:Databasesinstead of the real object names such assql_server1:Databases.Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #48644 done by [Mergify](https://mergify.com).