drop metrics (#54)

Signed-off-by: Florian Lehner <[email protected]>

Author: florianl

flake.nix

@@ -28,7 +28,6 @@
           # Filter source tree to avoid unnecessary rebuilds.
           includedSuffixes = [
             ".proto"
-            "metrics.json"
             "errors.json"
             "icon.png"
             "add-data.md"

src/storage/metricspec.rs

@@ -39,15 +39,14 @@ pub struct Db {
     pub stack_traces: StackTraces,
     pub stack_frames: StackFrames,
     pub executables: Executables,
-    pub metrics: Metrics,
 
     // Custom data storage.
     pub symbols: SymDb,
 }
 
 impl Db {
     /// Number of tables.
-    pub const NUM_TABLES: usize = 5;
+    pub const NUM_TABLES: usize = 4;
 
     /// Create or open the database.
     fn open() -> anyhow::Result<Arc<Self>> {
@@ -68,7 +67,6 @@ impl Db {
             stack_traces: open_or_create(db_dir)?,
             stack_frames: open_or_create(db_dir)?,
             executables: open_or_create(db_dir)?,
-            metrics: open_or_create(db_dir)?,
             symbols: SymDb::open_at(db_dir.join("symbols"))?,
         }))
     }
@@ -102,7 +100,6 @@ impl Db {
             &self.stack_traces,
             &self.stack_frames,
             &self.executables,
-            &self.metrics,
         ]
     }
 }
@@ -117,9 +114,6 @@ pub use dbtypes::*;
 mod tables;
 pub use tables::*;
 
-mod metricspec;
-pub use metricspec::*;
-
 mod errorspec;
 pub use errorspec::*;
 

src/storage/mod.rs

@@ -46,6 +46,8 @@ pub trait RawTable {
     fn cache(&self) -> &Mutex<LruCache<Vec<u8>, Vec<u8>>>;
 
     /// Clear the entire cache.
+    /// Helper function for tests only so far.
+    #[allow(dead_code)]
     fn clear_cache(&self) {
         let mut cache = self.cache().lock().unwrap();
         cache.clear();
@@ -246,6 +248,7 @@ pub enum MergeOperator<T: Table> {
     Default,
 
     /// Custom associative merge operator.
+    #[allow(dead_code)]
     Associative(MergeFn<T>),
 }
 

src/storage/table.rs

@@ -28,13 +28,11 @@
 //! could come up for devfiler.
 
 mod executables;
-mod metrics;
 mod stackframes;
 mod stacktraces;
 mod traceevents;
 
 pub use executables::*;
-pub use metrics::*;
 pub use stackframes::*;
 pub use stacktraces::*;
 pub use traceevents::*;

src/storage/tables/metrics.rs

@@ -65,7 +65,6 @@ impl DevfilerUi {
                 Box::new(tabs::ExecutablesTab::default()),
                 Box::new(tabs::LogTab::default()),
                 // Keep dev mode tabs below.
-                Box::new(tabs::MetricsTab::default()),
                 Box::new(tabs::TraceFreqTab::default()),
                 Box::new(tabs::DbStatsTab::default()),
                 Box::new(tabs::GrpcLogTab::default()),