Skip to content

Commit a774de4

Browse files
theletterfcursoragentGPT-5.4
authored
Roll out built-in Copilot auth and Elastic docs skill mapping (#185)
* Use APM skills in docs review workflow Install Elastic docs review skills through APM in the reusable PR review workflow so we can test cross-repo skill imports from a private caller repo without losing the embedded review guidance fallback. Co-signed-by: OpenAI GPT-5.4 Co-authored-by: Cursor <cursoragent@cursor.com> * Recompile docs review with gh-aw v0.79.6 Use the latest gh-aw compiler for the docs review workflow so the branch picks up the new Copilot auth behavior and no longer requires a dedicated COPILOT_GITHUB_TOKEN for smoke testing. Co-signed-by: OpenAI GPT-5.4 Co-authored-by: Cursor <cursoragent@cursor.com> * Roll out built-in Copilot auth and skill mapping. Update the gh-aw workflows and docs to use the built-in GitHub token path, and map Elastic docs skills to the reusable review and sweep workflows. Co-authored-by: GPT-5.4 <gpt-5.4@openai.com> Co-authored-by: Cursor <cursoragent@cursor.com> * Fix generated workflow pre-commit handling. Exclude the gh-aw maintenance workflow from actionlint until the generator stops emitting an invalid empty choice, and keep the repo's EOF normalization in sync. Co-authored-by: GPT-5.4 <gpt-5.4@openai.com> Co-authored-by: Cursor <cursoragent@cursor.com> * Exclude generated workflow from whitespace hook. Skip the gh-aw maintenance workflow in trailing-whitespace as well as actionlint so the generated header formatting no longer causes pre-commit failures. Co-authored-by: GPT-5.4 <gpt-5.4@openai.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: GPT-5.4 <gpt-5.4@openai.com>
1 parent 67a2f08 commit a774de4

53 files changed

Lines changed: 2089 additions & 616 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/aw/actions-lock.json

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,15 @@
5050
"version": "v7.0.1",
5151
"sha": "043fb46d1a93c77aae656e7c1c64a875d1fc6a0a"
5252
},
53-
"github/gh-aw-actions/setup-cli@v0.79.3": {
53+
"github/gh-aw-actions/setup-cli@v0.79.6": {
5454
"repo": "github/gh-aw-actions/setup-cli",
55-
"version": "v0.79.3",
56-
"sha": "ff3d7ecc684ffaf8c99e9ac7e40536e955a9776b"
55+
"version": "v0.79.6",
56+
"sha": "5c2fe865bb4dc46e1450f6ee0d0541d759aea73a"
5757
},
58-
"github/gh-aw-actions/setup@v0.79.3": {
58+
"github/gh-aw-actions/setup@v0.79.6": {
5959
"repo": "github/gh-aw-actions/setup",
60-
"version": "v0.79.3",
61-
"sha": "ff3d7ecc684ffaf8c99e9ac7e40536e955a9776b"
60+
"version": "v0.79.6",
61+
"sha": "5c2fe865bb4dc46e1450f6ee0d0541d759aea73a"
6262
},
6363
"microsoft/apm-action@v1.4.1": {
6464
"repo": "microsoft/apm-action",
@@ -69,6 +69,11 @@
6969
"repo": "microsoft/apm-action",
7070
"version": "v1.5.0",
7171
"sha": "4489b4be0069e2c8c4d44305c3d273fb9d50e647"
72+
},
73+
"microsoft/apm-action@v1.7.2": {
74+
"repo": "microsoft/apm-action",
75+
"version": "v1.7.2",
76+
"sha": "b48dd081eb0050f6d7f32d0e7caa0a59a2d419fd"
7277
}
7378
}
7479
}

.github/workflows/agentics-maintenance.yml

Lines changed: 607 additions & 0 deletions
Large diffs are not rendered by default.

.github/workflows/check-aw-updates.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
name: Recompile lock files and open PR if changed
1111
runs-on: ubuntu-latest
1212
env:
13-
GH_AW_VERSION: v0.79.3
13+
GH_AW_VERSION: v0.79.6
1414
permissions:
1515
id-token: write
1616
contents: read

.github/workflows/gh-aw-docs-applies-to-sweep.lock.yml

Lines changed: 150 additions & 58 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/gh-aw-docs-applies-to-sweep.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ description: |
77
88
inlined-imports: true
99
imports:
10+
- uses: shared/apm.md
11+
with:
12+
target: copilot
13+
packages:
14+
- elastic/elastic-docs-skills/skills/authoring/applies-to-tagging
1015
- gh-aw-fragments/formatting.md
1116
- gh-aw-fragments/rigor.md
1217
- gh-aw-fragments/mcp-pagination.md
@@ -61,11 +66,12 @@ on:
6166
default: ""
6267
secrets:
6368
COPILOT_GITHUB_TOKEN:
64-
required: true
69+
required: false
6570
concurrency:
6671
group: gh-aw-docs-applies-to-sweep-${{ github.run_id }}
6772
cancel-in-progress: false
6873
permissions:
74+
copilot-requests: write
6975
contents: read
7076
issues: read
7177
strict: false
@@ -252,6 +258,10 @@ steps:
252258

253259
You are an `applies_to` validator for an Elastic documentation repository. Your job is to audit the `applies_to` frontmatter key on a deterministically-selected slice of pages and emit a single labeled fix-issue with structured findings.
254260

261+
This workflow also installs the `docs-applies-to-tagging` APM skill from `elastic/elastic-docs-skills`.
262+
263+
Use that installed skill when it helps interpret version, deployment, product, or lifecycle applicability rules. Treat it as additive guidance, not as permission to skip the verified references and explicit rule checks in this workflow.
264+
255265
## Pre-fetched data
256266

257267
A pre-step has computed the in-scope file list:
@@ -264,7 +274,7 @@ Read with `cat` / `jq`. If `in_scope_count` is `0`, call `noop` with a path-awar
264274

265275
## Step 1: Validate applies_to autonomously
266276

267-
This workflow is autonomous. Do not invoke runtime skills or depend on a skill package being installed. For each in-scope file, read the frontmatter block at the top of the copy under `/tmp/gh-aw/sweep-data/scope/` and inspect the `applies_to` key.
277+
This workflow is autonomous. For each in-scope file, read the frontmatter block at the top of the copy under `/tmp/gh-aw/sweep-data/scope/` and inspect the `applies_to` key.
268278

269279
Audit only. Do not edit repo originals or scope copies. This sweep emits an issue, not a PR.
270280

@@ -276,6 +286,8 @@ Before filing any validity finding, verify the rule from one of these sources:
276286

277287
Use the published reference as the source of truth for allowed dimensions, keys, lifecycle states, and version formats. If the MCP server is unavailable and no local schema is available, call `noop` with `"applies_to reference unavailable; skipping applies_to sweep"` rather than emitting unverified findings.
278288

289+
When a finding depends on interpreting lifecycle, version-range, or dimension rules, explicitly use the installed `docs-applies-to-tagging` skill guidance.
290+
279291
Apply these rules after verification:
280292

281293
- Every page should include page-level `applies_to` frontmatter.

.github/workflows/gh-aw-docs-coherence-sweep.lock.yml

Lines changed: 48 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/gh-aw-docs-coherence-sweep.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,12 @@ on:
6767
default: ""
6868
secrets:
6969
COPILOT_GITHUB_TOKEN:
70-
required: true
70+
required: false
7171
concurrency:
7272
group: gh-aw-docs-coherence-sweep-${{ github.run_id }}
7373
cancel-in-progress: false
7474
permissions:
75+
copilot-requests: write
7576
contents: read
7677
issues: read
7778
strict: false

.github/workflows/gh-aw-docs-frontmatter-sweep.lock.yml

Lines changed: 156 additions & 58 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/gh-aw-docs-frontmatter-sweep.md

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ description: |
88
99
inlined-imports: true
1010
imports:
11+
- uses: shared/apm.md
12+
with:
13+
target: copilot
14+
packages:
15+
- elastic/elastic-docs-skills/skills/review/frontmatter-audit
16+
- elastic/elastic-docs-skills/skills/authoring/frontmatter-description
1117
- gh-aw-fragments/formatting.md
1218
- gh-aw-fragments/rigor.md
1319
- gh-aw-fragments/mcp-pagination.md
@@ -62,11 +68,12 @@ on:
6268
default: ""
6369
secrets:
6470
COPILOT_GITHUB_TOKEN:
65-
required: true
71+
required: false
6672
concurrency:
6773
group: gh-aw-docs-frontmatter-sweep-${{ github.run_id }}
6874
cancel-in-progress: false
6975
permissions:
76+
copilot-requests: write
7077
contents: read
7178
issues: read
7279
strict: false
@@ -253,6 +260,13 @@ steps:
253260

254261
You are a frontmatter quality reviewer for an Elastic documentation repository. Your job is to audit the frontmatter (`---` block at the top of each `.md` file) of a deterministically-selected slice of pages, and emit a single labeled fix-issue with structured findings that a human (and later, a fix-agent) can act on.
255262

263+
This workflow also installs these APM skills from `elastic/elastic-docs-skills`:
264+
265+
- `docs-frontmatter-audit`
266+
- `docs-frontmatter-description`
267+
268+
Use those installed skills when they help validate frontmatter requirements or judge whether a description is missing, weak, or mis-scoped. Treat them as additive guidance, not as permission to skip the deterministic repository evidence and explicit checks in this workflow.
269+
256270
## Pre-fetched data
257271

258272
A pre-step has computed the in-scope file list for this run:
@@ -276,10 +290,15 @@ If `in_scope_count` is `0`, call `noop` with a short message including the corpu
276290

277291
## Step 1: Audit the frontmatter
278292

279-
This workflow is autonomous. Do not invoke runtime skills or depend on a skill package being installed. For each in-scope file, read the frontmatter block at the top of the copy under `/tmp/gh-aw/sweep-data/scope/` and inspect only the fields covered by this sweep.
293+
This workflow is autonomous. For each in-scope file, read the frontmatter block at the top of the copy under `/tmp/gh-aw/sweep-data/scope/` and inspect only the fields covered by this sweep.
280294

281295
Use local repository evidence first. If a repository schema or docs-builder frontmatter reference is present in the checked-out source, use it for required-field confirmation. Use the Elastic docs MCP server only for targeted authoring guidance, not for broad corpus searches. Prefer `elastic-docs.get_document_by_url` for known guidance pages such as `/docs/contribute-docs/how-to/cumulative-docs/reference`, and `elastic-docs.search_docs` only when you need to discover a published frontmatter guidance page before citing it.
282296

297+
When the finding depends on description quality or metadata completeness rather than simple field presence, explicitly use the installed skill guidance:
298+
299+
- `docs-frontmatter-audit` for required-field and metadata-shape checks.
300+
- `docs-frontmatter-description` for judging description quality and user-facing scope.
301+
283302
Apply these rules:
284303

285304
- `description` should be present, non-empty, no more than 200 characters, specific to the page, and useful in search results. It must be a complete sentence, not a fragment or label.

0 commit comments

Comments
 (0)