Introduce an extension method for ReadOnlySpan<char> to acquire a trimmed relative path

Author: cotti

src/docs-assembler/Building/PublishEnvironmentUriResolver.cs

@@ -4,6 +4,7 @@
 
 using System.Collections.Frozen;
 using Documentation.Assembler.Configuration;
+using Documentation.Assembler.Extensions;
 using Elastic.Markdown.Links.CrossLinks;
 
 namespace Documentation.Assembler.Building;
@@ -142,10 +143,9 @@ private string GetSubPathPrefix(Uri crossLinkUri, ref string path)
 		if (originalPath == toc.SourcePathPrefix)
 			return string.Empty;
 
-		var newRelativePath = path.TrimStart('/').AsSpan().TrimStart(originalPath).ToString();
-		path = Path.Combine(toc.SourcePathPrefix, newRelativePath.TrimStart('/'));
+		var newRelativePath = path.AsSpan().GetTrimmedRelativePath(originalPath);
+		path = Path.Combine(toc.SourcePathPrefix, newRelativePath);
 
 		return string.Empty;
 	}
-
 }

src/docs-assembler/Extensions/SpanExtensions.cs

@@ -0,0 +1,17 @@
+// Licensed to Elasticsearch B.V under one or more agreements.
+// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
+// See the LICENSE file in the project root for more information
+
+namespace Documentation.Assembler.Extensions;
+
+public static class SpanExtensions
+{
+	public static string GetTrimmedRelativePath(this ReadOnlySpan<char> relativePath, string originalPath)
+	{
+		var trimmedInput = relativePath.TrimStart('/');
+		var newRelativePath = trimmedInput.StartsWith(originalPath, StringComparison.Ordinal)
+			? trimmedInput.Slice(originalPath.Length).TrimStart('/').ToString()
+			: trimmedInput.ToString();
+		return newRelativePath;
+	}
+}

src/docs-assembler/Navigation/GlobalNavigationPathProvider.cs

@@ -4,6 +4,7 @@
 
 using System.Collections.Immutable;
 using System.IO.Abstractions;
+using Documentation.Assembler.Extensions;
 using Elastic.Markdown;
 using Elastic.Markdown.Diagnostics;
 using Elastic.Markdown.Extensions.DetectionRules;
@@ -118,9 +119,7 @@ public GlobalNavigationPathProvider(GlobalNavigationFile navigationFile, Assembl
 
 		var originalPath = Path.Combine(match.Host, match.AbsolutePath.Trim('/')).TrimStart('/');
 		var relativePathSpan = relativePath.AsSpan();
-		var newRelativePath = relativePathSpan.StartsWith(originalPath, StringComparison.Ordinal)
-			? relativePathSpan.Slice(originalPath.Length).TrimStart('/').ToString()
-			: relativePathSpan.TrimStart(originalPath).TrimStart('/').ToString();
+		var newRelativePath = relativePathSpan.GetTrimmedRelativePath(originalPath);
 
 		var path = fs.Path.Combine(outputDirectory.FullName, toc.SourcePathPrefix, newRelativePath);