Only emit one error if capturing stdout goes wrong during assembler checkout (#1225)

* Only emit one error if capturing stdout goes wrong during assembler checkout

* Update src/tooling/docs-assembler/Sourcing/RepositorySourcesFetcher.cs

Co-authored-by: Jan Calanog <[email protected]>

---------

Co-authored-by: Jan Calanog <[email protected]>

Author: Mpdreamz

src/tooling/docs-assembler/Sourcing/RepositorySourcesFetcher.cs

@@ -125,8 +125,6 @@ private bool TryUpdateSource(string name, string branch, string relativePath, ID
 			_logger.LogInformation("Pull: {Name}\t{Branch}\t{RelativePath}", name, branch, relativePath);
 			// --allow-unrelated-histories due to shallow clones not finding a common ancestor
 			ExecIn(checkoutFolder, "git", "pull", "--depth", "1", "--allow-unrelated-histories", "--no-ff");
-			head = Capture(checkoutFolder, "git", "rev-parse", "HEAD");
-			return true;
 		}
 		catch (Exception e)
 		{
@@ -136,9 +134,12 @@ private bool TryUpdateSource(string name, string branch, string relativePath, ID
 				checkoutFolder.Delete(true);
 				checkoutFolder.Refresh();
 			}
+			return false;
 		}
 
-		return false;
+		head = Capture(checkoutFolder, "git", "rev-parse", "HEAD");
+
+		return true;
 	}
 
 	private string CheckoutFromScratch(Repository repository, string name, string branch, string relativePath,
@@ -183,19 +184,26 @@ private void ExecIn(IDirectoryInfo? workingDirectory, string binary, params stri
 	// ReSharper disable once UnusedMember.Local
 	private string Capture(IDirectoryInfo? workingDirectory, string binary, params string[] args)
 	{
-		// Try 10 times to capture the output of the command, if it fails we'll throw an exception on the last try
-		for (var i = 0; i < 9; i++)
+		// Try 10 times to capture the output of the command, if it fails, we'll throw an exception on the last try
+		Exception? e = null;
+		for (var i = 0; i <= 9; i++)
 		{
 			try
 			{
 				return CaptureOutput();
 			}
-			catch
+			catch (Exception ex)
 			{
-				// ignored
+				if (ex is not null)
+					e = ex;
 			}
 		}
-		return CaptureOutput();
+
+		if (e is not null)
+			collector.EmitError("", "failure capturing stdout", e);
+
+
+		return string.Empty;
 
 		string CaptureOutput()
 		{
@@ -208,9 +216,9 @@ string CaptureOutput()
 				ConsoleOutWriter = NoopConsoleWriter.Instance
 			};
 			var result = Proc.Start(arguments);
-			if (result.ExitCode != 0)
-				collector.EmitError("", $"Exit code: {result.ExitCode} while executing {binary} {string.Join(" ", args)} in {workingDirectory}");
-			var line = result.ConsoleOut.FirstOrDefault()?.Line ?? throw new Exception($"No output captured for {binary}: {workingDirectory}");
+			var line = result.ExitCode != 0
+				? throw new Exception($"Exit code is not 0. Received {result.ExitCode} from {binary}: {workingDirectory}")
+				: result.ConsoleOut.FirstOrDefault()?.Line ?? throw new Exception($"No output captured for {binary}: {workingDirectory}");
 			return line;
 		}
 	}