Skip to content

Commit 3cf99b9

Browse files
committed
Check the right build hash in integration tests
1 parent 69f5aae commit 3cf99b9

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

testing/integration/ess/package_version_test.go

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,12 @@ func TestComponentBuildHashInDiagnostics(t *testing.T) {
194194
require.Lenf(t, splits, 2,
195195
"expected split of beats output version to be split into 2, it was split into %q",
196196
strings.Join(splits, "|"))
197-
wantBuildHash := splits[0]
197+
filebeatBuildHash := splits[0]
198+
199+
// get the elastic-agent build hash
200+
agentVersion, err := f.ExecVersion(ctx)
201+
require.NoError(t, err, "failed to get agent version")
202+
agentCommit := agentVersion.Binary.Commit
198203

199204
diagZip, err := f.ExecDiagnostics(ctx)
200205
require.NoError(t, err, "failed collecting diagnostics")
@@ -251,9 +256,20 @@ func TestComponentBuildHashInDiagnostics(t *testing.T) {
251256
require.NoError(t, err, "could not parse state.yaml (%s)", stateYAML.Name())
252257

253258
for _, c := range state.Components {
254-
assert.Equalf(t, wantBuildHash, c.State.VersionInfo.BuildHash,
259+
var expectedCommit, expectedBuildHash string
260+
switch c.State.VersionInfo.Name {
261+
case "beats-receiver":
262+
expectedBuildHash = agentCommit
263+
expectedCommit = agentCommit
264+
case "beat-v2-client":
265+
expectedBuildHash = filebeatBuildHash
266+
expectedCommit = filebeatBuildHash
267+
default:
268+
t.Errorf("got unknown value in version_info.name: %s", c.State.VersionInfo.Name)
269+
}
270+
assert.Equalf(t, expectedBuildHash, c.State.VersionInfo.BuildHash,
255271
"component %s: VersionInfo.BuildHash mismatch", c.ID)
256-
assert.Equalf(t, wantBuildHash, c.State.VersionInfo.Meta.Commit,
272+
assert.Equalf(t, expectedCommit, c.State.VersionInfo.Meta.Commit,
257273
"component %s: VersionInfo.Meta.Commit mismatch", c.ID)
258274
}
259275

0 commit comments

Comments
 (0)