Skip to content

Commit 798b920

Browse files
pchilaycombinator
andauthored
move FIPS related env vars inline for FIPS unit tests (#10960)
* move FIPS related env vars inline for FIPS unit tests * Add inline comment * Only keep GODEBUG=fips140=only in the command * Clarify comment --------- Co-authored-by: Shaunak Kashyap <[email protected]>
1 parent ce40b83 commit 798b920

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.buildkite/pipeline.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,12 @@ steps:
6666

6767
- label: "Unit tests - fips140=only Ubuntu 22.04"
6868
key: "unit-tests-2204-fips140-only"
69-
command: ".buildkite/scripts/steps/unit-tests.sh"
69+
# Note: The GODEBUG=fips140=only environment variable must be set in the command itself (as opposed to
70+
# in the env block) so that it is applied *only* to the 'go' command invoked by the script, and
71+
# not to any other Go code executed as part of the Buildkite agent itself.
72+
command: 'GODEBUG="fips140=only" .buildkite/scripts/steps/unit-tests.sh'
7073
env:
7174
FIPS: "true"
72-
GODEBUG: "fips140=only"
7375
artifact_paths:
7476
- "build/TEST-*.html"
7577
- "build/TEST-*.xml"

0 commit comments

Comments
 (0)