Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 19, 2025

Replace tibdex/github-app-token with actions/create-github-app-token

This PR addresses issue #10061 by replacing the archived tibdex/github-app-token action with actions/create-github-app-token.

Completed:

  • Located all instances of tibdex/github-app-token in the repository
  • Found 1 occurrence in .github/workflows/serverless-project.yml
  • Verified no custom actions use the deprecated action
  • Analyzed the current configuration format
  • Replaced tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a with actions/create-github-app-token@v2
  • Converted configuration format:
    • Changed app_id to app-id
    • Changed private_key to private-key
    • Converted permissions from JSON object to individual permission fields:
      • permission-checks: read
      • permission-contents: write
      • permission-pull-requests: write
    • Converted repositories from JSON array ["observability-test-environments"] to YAML list format
  • Validated YAML syntax is correct
  • Verified downstream token usage remains compatible (${{ steps.get_token.outputs.token }})

Files modified:

  • .github/workflows/serverless-project.yml - Updated GitHub App token generation step

Validation performed:

  • ✅ YAML syntax validation passed
  • ✅ Verified no more instances of tibdex/github-app-token remain
  • ✅ Confirmed output token name compatibility with downstream steps
  • ✅ All permission mappings correctly converted

The replacement follows the exact pattern provided in the issue description and maintains full functionality while using the supported actions/create-github-app-token action.

Fixes #10061.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI assigned Copilot and v1v Sep 19, 2025
Copy link
Contributor Author

Copilot AI commented Sep 19, 2025

@v1v 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2025

This pull request does not have a backport label. Could you fix it @copilot? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@v1v v1v added skip-changelog backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch labels Sep 19, 2025
@v1v v1v marked this pull request as ready for review September 19, 2025 15:44
@v1v v1v requested a review from a team as a code owner September 19, 2025 15:44
Copilot AI requested a review from v1v September 19, 2025 15:48
@v1v v1v changed the title [WIP] Replace tibdex/github-app-token with actions/create-github-app-token Replace tibdex/github-app-token with actions/create-github-app-token Sep 19, 2025
@v1v v1v requested a review from a team September 19, 2025 15:55
Copy link
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n enabled auto-merge (squash) September 22, 2025 07:02
@v1v v1v requested a review from a team September 22, 2025 09:18
@pierrehilbert
Copy link
Contributor

@v1v What should we do with that PR?

@v1v
Copy link
Member

v1v commented Dec 8, 2025

buildkite test this

@v1v v1v requested a review from a team as a code owner December 8, 2025 08:52
@v1v v1v requested review from pchila and ycombinator December 8, 2025 08:52
- name: Get token
id: get_token
uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2.1.0
uses: actions/create-github-app-token@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pinned to a specific commit as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we follow https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions for the majority of the third-party actions, in this case, we don't do that, it's coming from actions and we trust those actions.

@v1v
Copy link
Member

v1v commented Dec 8, 2025

buildkite test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @v1v @Copilot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch backport-9.1 Automated backport to the 9.1 branch skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace tibdex/github-app-token with actions/create-github-app-token

7 participants