-
Notifications
You must be signed in to change notification settings - Fork 204
Replace tibdex/github-app-token with actions/create-github-app-token #10062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@v1v 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
|
This pull request does not have a backport label. Could you fix it @copilot? 🙏
|
Co-authored-by: v1v <[email protected]>
fr4nc1sc0-r4m0n
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@v1v What should we do with that PR? |
|
buildkite test this |
| - name: Get token | ||
| id: get_token | ||
| uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2.1.0 | ||
| uses: actions/create-github-app-token@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be pinned to a specific commit as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we follow https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions for the majority of the third-party actions, in this case, we don't do that, it's coming from actions and we trust those actions.
|
buildkite test this |
💚 Build Succeeded
History
cc @v1v @Copilot |
Replace tibdex/github-app-token with actions/create-github-app-token
This PR addresses issue #10061 by replacing the archived
tibdex/github-app-tokenaction withactions/create-github-app-token.Completed:
tibdex/github-app-tokenin the repository.github/workflows/serverless-project.ymltibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73awithactions/create-github-app-token@v2app_idtoapp-idprivate_keytoprivate-keypermission-checks: readpermission-contents: writepermission-pull-requests: write["observability-test-environments"]to YAML list format${{ steps.get_token.outputs.token }})Files modified:
.github/workflows/serverless-project.yml- Updated GitHub App token generation stepValidation performed:
tibdex/github-app-tokenremainThe replacement follows the exact pattern provided in the issue description and maintains full functionality while using the supported
actions/create-github-app-tokenaction.Fixes #10061.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.