Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2025

What does this PR do?

Merge multiple agent.* keys when handling config.

Why is it important?

Multiple keys were getting silently ignored, leading to configs that contain:

agent.logging.level: error
agent.logging.to_files: true

not working as expected.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

Standalone agent configs will no longer silently ignore multiple agent.* attributes.

How to test this PR locally

Create a stand-alone config with multiple agent.* entries such as:

agent.logging.level: debug
agent.logging.to_stderr: true
agent:
  download:
    sourceURI: https://artifacts.elastic.co/downloads/
  monitoring:
    enabled: true
    use_output: default
    logs: false
    metrics: false
    traces: true
    namespace: default

and observe that the logging entries are configured correctly.

Related issues

@mergify mergify bot added the backport label Dec 5, 2025
@mergify mergify bot requested a review from a team as a code owner December 5, 2025 17:22
@mergify mergify bot requested review from swiatekm and ycombinator and removed request for a team December 5, 2025 17:22
@github-actions github-actions bot added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Dec 5, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@michel-laterman michel-laterman enabled auto-merge (squash) December 5, 2025 18:00
@michel-laterman michel-laterman merged commit bee420c into 9.2 Dec 5, 2025
23 checks passed
@michel-laterman michel-laterman deleted the mergify/bp/9.2/pr-11619 branch December 5, 2025 18:42
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cc @michel-laterman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants