Skip to content

Conversation

@olegsu
Copy link
Contributor

@olegsu olegsu commented Jul 3, 2025

What does this PR do?

Register agentless component to the internal development platform

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@olegsu olegsu requested review from a team as code owners July 3, 2025 17:38
@olegsu olegsu enabled auto-merge (squash) July 3, 2025 17:39
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2025

This pull request does not have a backport label. Could you fix it @olegsu? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

blakerouse
blakerouse previously approved these changes Jul 3, 2025
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pazone
pazone previously approved these changes Jul 8, 2025
Copy link
Contributor

@pazone pazone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor note: quotes are not required for the values in this context.

@olegsu olegsu dismissed stale reviews from pazone and blakerouse via ce8bcc9 July 8, 2025 12:24
@olegsu olegsu force-pushed the register-agentless branch from 6c8ab26 to ce8bcc9 Compare July 8, 2025 12:24
@olegsu olegsu force-pushed the register-agentless branch from ce8bcc9 to 340f8a1 Compare July 8, 2025 12:25
@olegsu olegsu disabled auto-merge July 8, 2025 13:42
@olegsu olegsu merged commit 29d8f3d into main Jul 8, 2025
9 checks passed
@olegsu olegsu deleted the register-agentless branch July 8, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants